Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test statement.cancel() works when MultiSubnetFailover is set to true #173

Merged

Conversation

xiangyushawn
Copy link
Contributor

for issue #144 and PR #160

@codecov-io
Copy link

codecov-io commented Mar 6, 2017

Codecov Report

Merging #173 into dev will increase coverage by 0.2%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               dev     #173     +/-   ##
==========================================
+ Coverage     29.7%   29.91%   +0.2%     
- Complexity    1248     1252      +4     
==========================================
  Files           97       97             
  Lines        23305    23305             
  Branches      3871     3871             
==========================================
+ Hits          6923     6971     +48     
+ Misses       15028    14960     -68     
- Partials      1354     1374     +20
Flag Coverage Δ Complexity Δ
#JDBC41 29.82% <ø> (+0.21%) 1249 <ø> (+4)
#JDBC42 29.84% <ø> (+0.25%) 1251 <ø> (+7)
Impacted Files Coverage Δ Complexity Δ
src/main/java/microsoft/sql/DateTimeOffset.java 37.14% <0%> (-2.86%) 8% <0%> (-2%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 17.61% <0%> (-0.33%) 127% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 45.81% <0%> (ø) 182% <0%> (ø)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 38.86% <0%> (+0.08%) 193% <0%> (+3%)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 53.4% <0%> (+0.5%) 108% <0%> (+1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 33.77% <0%> (+1.66%) 0% <0%> (ø)
.../java/com/microsoft/sqlserver/jdbc/StreamDone.java 63.63% <0%> (+13.63%) 16% <0%> (+2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 369e5e0...f3ddcd4. Read the comment docs.

@ahmad-ibra ahmad-ibra requested review from ahmad-ibra and removed request for ahmad-ibra March 7, 2017 20:58
@ahmad-ibra ahmad-ibra self-assigned this Mar 7, 2017
@ahmad-ibra ahmad-ibra merged commit fb8bec6 into microsoft:dev Mar 7, 2017
@xiangyushawn xiangyushawn deleted the tests-for-query-cancellation-issue branch March 7, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants