Lobs tests #168

AfsanehR-zz · 2017-03-04T00:36:03Z

test framework update for lobs tests

codecov-io · 2017-03-04T00:43:24Z

Codecov Report

Merging #168 into dev will increase coverage by 1.45%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##               dev     #168      +/-   ##
===========================================
+ Coverage     29.7%   31.15%   +1.45%     
- Complexity    1248     1322      +74     
===========================================
  Files           97       97              
  Lines        23305    23305              
  Branches      3871     3871              
===========================================
+ Hits          6923     7261     +338     
+ Misses       15028    14566     -462     
- Partials      1354     1478     +124

Flag	Coverage Δ	Complexity Δ
#JDBC41	`31.07% <ø> (+1.46%)`	`1317 <ø> (+72)`	✅
#JDBC42	`31.07% <ø> (+1.48%)`	`1321 <ø> (+77)`	✅

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/microsoft/sql/DateTimeOffset.java	`37.14% <0%> (-2.86%)`	`8% <0%> (-2%)`
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java	`45.89% <0%> (+0.07%)`	`183% <0%> (+1%)`	✅
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java	`38.47% <0%> (+0.23%)`	`50% <0%> (ø)`	❌
.../microsoft/sqlserver/jdbc/SQLServerConnection.java	`39.17% <0%> (+0.39%)`	`193% <0%> (+3%)`	✅
...ava/com/microsoft/sqlserver/jdbc/SQLCollation.java	`92.49% <0%> (+0.48%)`	`12% <0%> (+1%)`	✅
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java	`68.85% <0%> (+0.84%)`	`2% <0%> (+2%)`	✅
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java	`23.88% <0%> (+0.89%)`	`39% <0%> (+3%)`	✅
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java	`20.17% <0%> (+1.16%)`	`54% <0%> (+3%)`	✅
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java	`32.54% <0%> (+1.18%)`	`22% <0%> (+1%)`	✅
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java	`39.7% <0%> (+1.47%)`	`10% <0%> (+1%)`	✅
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 369e5e0...4d6baa0. Read the comment docs.

v-nisidh · 2017-03-10T01:01:36Z

src/test/java/com/microsoft/sqlserver/testframework/sqlType/SqlBinary.java

        generatePrecision();
    }

    /**
     * create random data for binary and varbinary column
     */
    public Object createdata() {
-        int dataLength = ThreadLocalRandom.current().nextInt(precision);
+        int dataLength = ThreadLocalRandom.current().nextInt(5);// precision


Please add precision instead of 5

v-nisidh · 2017-03-10T01:03:50Z

src/test/java/com/microsoft/sqlserver/testframework/sqlType/SqlType.java

+     * @return
+     * @throws Exception
+     */
+    public boolean canconvert(Class target,


Method name should be CamelCase

v-nisidh · 2017-03-10T01:50:30Z

Linking more test cases for Issue #16

AfsanehR-zz added 4 commits March 3, 2017 15:06

added lobs Test and changes to test framework

fec3b3e

update for using lambda expression

04fb974

fix travis-ci failure

e0a396a

update lambda expressions

4b2abde

v-nisidh reviewed Mar 10, 2017

View reviewed changes

v-nisidh approved these changes Mar 10, 2017

View reviewed changes

post review commits

4d6baa0

v-nisidh approved these changes Mar 10, 2017

View reviewed changes

v-nisidh merged commit 171c8e8 into microsoft:dev Mar 10, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lobs tests #168

Lobs tests #168

AfsanehR-zz commented Mar 4, 2017

codecov-io commented Mar 4, 2017 •

edited

Loading

v-nisidh Mar 10, 2017

v-nisidh Mar 10, 2017

v-nisidh commented Mar 10, 2017

Lobs tests #168

Lobs tests #168

Conversation

AfsanehR-zz commented Mar 4, 2017

codecov-io commented Mar 4, 2017 • edited Loading

Codecov Report

v-nisidh Mar 10, 2017

Choose a reason for hiding this comment

v-nisidh Mar 10, 2017

Choose a reason for hiding this comment

v-nisidh commented Mar 10, 2017

codecov-io commented Mar 4, 2017 •

edited

Loading