feat: document/test support for axe-core v3.4.1 and axe-cli v3.2.0 #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [axe-core](https://github.com/dequelabs/axe-core) from 3.3.2 to 3.4.1. - [Release notes](https://github.com/dequelabs/axe-core/releases) - [Changelog](https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md) - [Commits](dequelabs/axe-core@v3.3.2...v3.4.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
smoralesd
approved these changes
Jan 7, 2020
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Neither axe-core v3.4.1 nor axe-cli v3.2.0 contain any breaking output format changes, so axe-sarif-converter was already compatible with both of them. This PR updates our test cases to include verification of this compatibility.
This PR also checks in code to generate test cases for future axe-core updates, and documents the process for performing such an update in the README under a new subsection of
Contributing.Review suggestions:
README.mdchanges; this provides a broad understanding of the changes and the expected usage of the new generator./src/test-resources/*.{json|sarif}, review by comparing against the similar files for old axe versions to satisfy yourself that they've been generated consistently and follow the same format./src/test-resources/generator)Pull request checklist
fix:,feat:, etc, and is suitable for user-facing release notes)BREAKING CHANGE:yarn precheckin