Revert assertion addition #22622
Merged
Revert assertion addition #22622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Mar 16, 2018
RyanCavanaugh
approved these changes
Mar 16, 2018
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
Mar 27, 2018
weswigham
added a commit
that referenced
this pull request
Mar 28, 2018
mmorearty
pushed a commit
to Asana/TypeScript
that referenced
this pull request
Mar 28, 2018
|
@weswigham has this been ported to release-2.8 branch? |
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just not true - alias symbol targets can be named whatever 🤷♂️ (but we can still only reuse the target's cached type if the name is the same.)
Fixes a test in our RWC suite.