Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fix to add missing 'this.' for property accesses #13759

Merged
merged 4 commits into from
Jan 30, 2017
Merged

Quick fix to add missing 'this.' for property accesses #13759

merged 4 commits into from
Jan 30, 2017

Conversation

DanielRosenwasser
Copy link
Member

No description provided.

@DanielRosenwasser DanielRosenwasser added the Domain: Quick Fixes Editor-provided fixes, often called code actions. label Jan 30, 2017
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 2.2 milestone Jan 30, 2017
mhegazy
mhegazy approved these changes Jan 30, 2017
View reviewed changes
Copy link
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna add the static check as well?

@aozgaa
Copy link
Contributor

aozgaa commented Jan 30, 2017

LGTM :)

@DanielRosenwasser
Copy link
Member Author

@mhegazy yes, it's been on my computer for a few months now. 😄

Thanks guys!

@DanielRosenwasser DanielRosenwasser merged commit d38bc54 into master Jan 30, 2017
@DanielRosenwasser DanielRosenwasser deleted the fixMissingThis branch January 30, 2017 21:03
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhegazy mhegazy mhegazy approved these changes

Assignees
No one assigned
Labels
Domain: Quick Fixes Editor-provided fixes, often called code actions.
Projects
None yet
Milestone
TypeScript 2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielRosenwasser @aozgaa @mhegazy @msftclas