-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing Commas in Function Param Lists #7279
Comments
Approved for whatever the Stage 3 proposal says |
PRs are welcomed of course. the change should be limited to the parser, so would be a rather easy change to make. |
Actually, signature help and overload resolution could potentially be affected by this. |
Is anyone taking on this? If not I can. I spent almost my entire weekend playing with the parser and scanner. @DanielRosenwasser, what do you mean by signature help and overload resolution? |
@nojvek signature help is the little tooltip that shows up to show the parameters & their types when you call a function. I mean that we specifically check if you have a trailing comma to see if there is a "better" overload in some cases. For instance, here's a call to Here's a call with one argument and a trailing comma: |
So in general, my warning is that we can't do that anymore if we support trailing commas in argument lists. If we do that, we'd impair the experience of anyone who wants to use trailing commas in calls. |
do not think this is an issue we should change the design of signature help for. you will get the pop up, you could decide to dismiss it an keep the comma. |
Woohoo! |
Personal opinion to any users : If you are thinking about adding a trailing comma to a function you might want to reconsider and change the function parameters to a single object https://basarat.gitbooks.io/typescript/content/docs/tips/functionParameters.html 🌹 |
* Added pubsub argument to SubscriptionManager to allow for different kinds of PubSub Engines * Updated typescript dependencies to 2.0.0 to allow for the current graphql typings to work. see microsoft/TypeScript#7279
https://jeffmo.github.io/es-trailing-function-commas/
This proposal is Stage 3 according to https://github.com/tc39/ecma262, so seems like its at an appropriate stability for TypeScript team to implement it.
This would allow function definitions and calls in the following style:
Benefits: https://github.com/jeffmo/es-trailing-function-commas/blob/master/proposal_presentation_slides.pdf
In addition to all of the above, I suspect the extra "verbosity" of TypeScript's inline types makes this feature even more attractive in TypeScript than in vanilla JS. I feel this particularly in class constructors, which can also have
private
annotations, and possibly areadonly
annotation coming down the pipe.The text was updated successfully, but these errors were encountered: