-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-2.9] Updates the graph before checking if file is present in project for error checking #24817
Conversation
…rror checking When file is moved using getEditsForFileRename, the watch notification could be delayed This could result in project updates in background that could be delayed and result in file not present in the project after its synchronised Fixes #24547
@mjbvz can i get you to take a look at this change? can you give it a quick test and verify it does fix the original issue? |
Thanks for taking a look @sheetalkamat! I'm actually still seeing this issue but am not sure if we are doing something wrong on the VS Code side. Here are the logs: Relevant section:
|
@mjbvz The only errors I see in the log are from plugin loadin which were raised even before the file move as well:
|
When file is moved using getEditsForFileRename, the watch notification could be delayed
This could result in project updates in background that could be delayed and result in file not present in the project after its synchronised
Fixes #24547
Port of #24816 to release-2.9