Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DefinitelyTyped type definitions before publishing a new version #14256

Closed
tkrotoff opened this issue Feb 23, 2017 · 6 comments
Closed

Fix DefinitelyTyped type definitions before publishing a new version #14256

tkrotoff opened this issue Feb 23, 2017 · 6 comments
Labels
Infrastructure Issue relates to TypeScript team infrastructure

Comments

@tkrotoff
Copy link

tkrotoff commented Feb 23, 2017

Problem:
Each TypeScript release breaks popular DefinitelyTyped type definitions, example with TypeScript 2.2 release:

Not a good developer experience

Solution:
Fix the most popular DefinitelyTyped type definitions before publishing on npm

@corbinu
Copy link

corbinu commented Feb 23, 2017

Given the issue with loads at least was that the change would break older versions of TS. Maybe if there was some sort of @next option for DefinitelyTyped that way at least we call you have updated to that version of the definition when the RC has launched. That would have made things a little easier at least.

@jaredmahan
Copy link

When can we expect isomorphic-fetch type fixes to be deployed? Waiting on this currently...

@mhegazy
Copy link
Contributor

mhegazy commented Feb 23, 2017

@types/[email protected] is already out and should have the fix.

@mhegazy
Copy link
Contributor

mhegazy commented Feb 23, 2017

For lodash, the change DefinitelyTyped/DefinitelyTyped#14662 needs to be updated and then we can merge it.

@mhegazy
Copy link
Contributor

mhegazy commented Feb 23, 2017

As for the original request, we used to validate against every drop of the compiler but as the size of DT grew it became harder to do that.
I agree We should be running the validation on all DT packages at least once before every release. @andy-ms is updating the testing system to make this doable.

@mhegazy mhegazy assigned ghost Feb 23, 2017
@mhegazy mhegazy added the Infrastructure Issue relates to TypeScript team infrastructure label Feb 23, 2017
@weswigham
Copy link
Member

We do this regularly now, thanks to the @typescript-bot run dt command (not just before publish, but regularly before merge), in addition to nightly testing of DT vs the nightly TS. 😄

@weswigham weswigham unassigned ghost Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants