Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Unified Logging Base Class for Python #2159

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

lhrotk
Copy link
Contributor

@lhrotk lhrotk commented Jan 22, 2024

What changes are proposed in this pull request?

Provide a python implementation of unified logging's base class.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.

Copy link

Hey @lhrotk 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@lhrotk
Copy link
Contributor Author

lhrotk commented Jan 22, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lhrotk lhrotk changed the title Add Unified Logging Base Class for Python chore: Add Unified Logging Base Class for Python Jan 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbc022c) 86.35% compared to head (289e496) 77.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2159      +/-   ##
==========================================
- Coverage   86.35%   77.87%   -8.48%     
==========================================
  Files         325      325              
  Lines       16959    16959              
  Branches     1524     1524              
==========================================
- Hits        14645    13207    -1438     
- Misses       2314     3752    +1438     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lhrotk
Copy link
Contributor Author

lhrotk commented Jan 22, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gorgeous

@mhamilton723 mhamilton723 merged commit 9b008b5 into microsoft:master Jan 22, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants