Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update openai completion #2142

Merged
merged 7 commits into from
Dec 5, 2023

Conversation

JessicaXYWang
Copy link
Contributor

No description provided.

@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Hey @JessicaXYWang 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ca2016) 86.18% compared to head (7c095fb) 86.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2142      +/-   ##
==========================================
- Coverage   86.18%   86.15%   -0.04%     
==========================================
  Files         312      312              
  Lines       16483    16486       +3     
  Branches     1462     1456       -6     
==========================================
- Hits        14206    14203       -3     
- Misses       2277     2283       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JessicaXYWang JessicaXYWang changed the title WIP: update openai completion, testing fix: update openai completion Nov 28, 2023
@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JessicaXYWang
Copy link
Contributor Author

Concurrency, ConcurrentTimeout are set properly. @mhamilton723 please review, thanks!

@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit 7771c96 into microsoft:master Dec 5, 2023
67 checks passed
@JessicaXYWang JessicaXYWang deleted the fix_time_out branch December 9, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants