Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modified the search engine in the demo notebook to bing #2013

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

sherylZhaoCode
Copy link
Contributor

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@github-actions
Copy link

Hey @sherylZhaoCode 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@sherylZhaoCode
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary by GPT-4

This diff shows changes made to a Jupyter Notebook file. The main changes include:

  1. Removing the mention of SerpAPI and its related code, as it is no longer needed.
  2. Adding Bing Search API related code and environment variables.
  3. Updating the sequential_chain to include the new prompt_generation_chain and web_search_agent with Bing Search API.
  4. Some minor formatting and text changes.

These changes indicate that the notebook has been updated to use Bing Search API instead of SerpAPI for web search functionality in the LangchainTransformer example.

Suggestions

No suggestions are needed as the changes in this PR seem appropriate.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Merging #2013 (ad1aebf) into master (0c1c84b) will decrease coverage by 10.72%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2013       +/-   ##
===========================================
- Coverage   87.02%   76.31%   -10.72%     
===========================================
  Files         306      306               
  Lines       16064    16064               
  Branches      840      840               
===========================================
- Hits        13980    12259     -1721     
- Misses       2084     3805     +1721     

see 58 files with indirect coverage changes

@sherylZhaoCode
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 2013 in repo microsoft/SynapseML

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit 25c4582 into master Jul 12, 2023
@mhamilton723 mhamilton723 deleted the sherylZhao/modify_search_method_in_demo branch July 12, 2023 13:58
JessicaXYWang pushed a commit to JessicaXYWang/SynapseML that referenced this pull request Sep 14, 2023
…ft#2013)

* modified the search engine in the demo notebook to bing

* reformatted

* Update notebooks/features/cognitive_services/CognitiveServices - LangchainTransformer.ipynb

---------

Co-authored-by: Mark Hamilton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants