fix: improve tolerance for error handling multivariate anomaly detection #1991
Conversation
|
/azp run |
|
Hey @eisber 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary by GPT-4
The code changes in the MultivariateAnomalyDetection.scala file remove the conversion of the "errors" field to a sequence of DMAError objects and instead directly convert it to a JSON string. This change is made in two places: in the MADUtils object and in the SimpleFitMultivariateAnomaly class.
In the MultivariateAnomalyDetectorSchemas.scala file, the DMAError case class is modified to have optional fields for "code" and "message". This change allows for more flexibility when handling errors, as they may not always have a code or message associated with them.
Suggestions
No suggestions are needed as the changes in this PR seem appropriate.
Codecov Report
@@ Coverage Diff @@
## master #1991 +/- ##
=======================================
Coverage 87.01% 87.01%
=======================================
Files 306 306
Lines 16063 16062 -1
Branches 850 827 -23
=======================================
Hits 13977 13977
+ Misses 2086 2085 -1
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -28,7 +28,7 @@ case class DMASummary(status: String, | |||
|
|
|||
| object DMAError extends SparkBindings[DMAError] | |||
|
|
|||
| case class DMAError(code: String, message: String) | |||
| case class DMAError(code: Option[String], message: Option[String]) | |||
There was a problem hiding this comment.
if this is unused can you remove?
There was a problem hiding this comment.
it's still used in DMASummary
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Related Issues/PRs
Improve error handling for multivariate anomaly detection
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?