-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix import error on using the cognitive services on AML spark clusters #1951
Conversation
Hey @mhamilton723 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1951 +/- ##
==========================================
+ Coverage 86.11% 86.98% +0.86%
==========================================
Files 305 305
Lines 15993 15993
Branches 839 839
==========================================
+ Hits 13772 13911 +139
+ Misses 2221 2082 -139
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary by GPT-4
The code change adds a try-except block around the import statement and the following lines that use the imported module. This is done to handle the ModuleNotFoundError
exception that might be raised if the module is not found. If the exception is raised, it will be caught and passed, allowing the program to continue running without any issues.
Here's a summary of what has been changed:
- Added a try-except block around the import statement for
synapse.ml.mlflow
. - If
ModuleNotFoundError
is raised, it will be caught and passed. - The rest of the code remains unchanged.
This change ensures that if the module is not found, it won't cause any issues in the program execution, and it will continue running without any problems.
Suggestions
No suggestions are needed as the changes in this PR seem to be appropriate and well-implemented.
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentation
folder.Make sure you choose the correct class
estimators/transformers
and namespace.DocTable
points to correct API link.yarn run start
to make sure the website renders correctly.<!--pytest-codeblocks:cont-->
before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTests
job pass in the pipeline.