chore: conform R-setup.md to reality #1946

niehaus59 · 2023-05-01T22:04:48Z

Related Issues/PRs

#1943
#1943

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

Updated docs in R-setup.md to reflect the fact we don't have an uber package for R

How is this patch tested?

I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

No. You can skip this section.
Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

No. You can skip this section.
Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add  before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

acrolinxatmsft1 · 2023-05-01T22:04:58Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/reference/R-setup.md	79	100	70	link	✅

More information about Acrolinx

github-actions · 2023-05-01T22:05:01Z

Hey @niehaus59 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

fix: Fix LightGBM crashes with empty partitions
feat: Make HTTP on Spark back-offs configurable
docs: Update Spark Serving usage
build: Add codecov support
perf: improve LightGBM memory usage
refactor: make python code generation rely on classes
style: Remove nulls from CNTKModel
test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

niehaus59 · 2023-05-01T22:07:35Z

/azp run

azure-pipelines · 2023-05-01T22:07:41Z

Pull request contains merge conflicts.

acrolinxatmsft1 · 2023-05-01T22:08:46Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/reference/R-setup.md	79	100	70	link	✅

More information about Acrolinx

acrolinxatmsft1 · 2023-05-02T01:48:05Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/reference/R-setup.md	94	100	100	link	✅

More information about Acrolinx

niehaus59 · 2023-05-02T14:32:45Z

/azp run

azure-pipelines · 2023-05-02T14:32:56Z

Azure Pipelines successfully started running 1 pipeline(s).

acrolinxatmsft1 · 2023-05-02T14:33:13Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/reference/R-setup.md	94	100	100	link	✅

More information about Acrolinx

acrolinxatmsft1 · 2023-05-03T21:05:55Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/reference/R-setup.md	78	100	53	link	✅
website/docs/reference/developer-readme.md	84	100	65	link	✅

More information about Acrolinx

niehaus59 · 2023-05-03T21:08:50Z

/azp run

azure-pipelines · 2023-05-03T21:09:00Z

Azure Pipelines successfully started running 1 pipeline(s).

website/docs/reference/developer-readme.md

mhamilton723

Amazing

codecov-commenter · 2023-05-03T21:22:31Z

Codecov Report

Merging #1946 (dc4fc1d) into master (6efa060) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1946      +/-   ##
==========================================
- Coverage   87.05%   86.95%   -0.11%     
==========================================
  Files         305      305              
  Lines       15993    15993              
  Branches      839      839              
==========================================
- Hits        13923    13907      -16     
- Misses       2070     2086      +16

see 5 files with indirect coverage changes

acrolinxatmsft1 · 2023-05-03T21:31:18Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/reference/R-setup.md	78	100	53	link	✅
website/docs/reference/developer-readme.md	85	100	62	link	✅

More information about Acrolinx

niehaus59 · 2023-05-03T21:33:50Z

/azp run

azure-pipelines · 2023-05-03T21:34:00Z

Azure Pipelines successfully started running 1 pipeline(s).

acrolinxatmsft1 · 2023-05-25T18:44:59Z

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article	Acrolinx score	Word and Phrases Score	Correctness Score	Scorecard	Processed
website/docs/reference/R-setup.md	78	100	53	link	✅
website/docs/reference/developer-readme.md	85	100	62	link	✅

More information about Acrolinx

conform R-setup.md to reality

6c34d20

niehaus59 requested review from mhamilton723 and ppruthi May 1, 2023 22:04

niehaus59 requested a review from serena-ruan as a code owner May 1, 2023 22:04

niehaus59 and others added 2 commits May 1, 2023 15:08

Merge branch 'master' into manieh/update-r-docs

6e2c5f0

update for acrolinx

9cca7ef

Merge branch 'master' into manieh/update-r-docs

66c9c9c

augment readmes for winutils and spark installation

6b0d1b4

mhamilton723 reviewed May 3, 2023

View reviewed changes

website/docs/reference/developer-readme.md Outdated Show resolved Hide resolved

mhamilton723 reviewed May 3, 2023

View reviewed changes

website/docs/reference/developer-readme.md Outdated Show resolved Hide resolved

mhamilton723 requested changes May 3, 2023

View reviewed changes

remove spark install from developer-readme and fix winutil instructions

dc4fc1d

ppruthi approved these changes May 11, 2023

View reviewed changes

Merge branch 'master' into manieh/update-r-docs

af2e3d0

mhamilton723 merged commit fbb0d0a into microsoft:master May 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: conform R-setup.md to reality #1946

chore: conform R-setup.md to reality #1946

niehaus59 commented May 1, 2023

acrolinxatmsft1 commented May 1, 2023

github-actions bot commented May 1, 2023

niehaus59 commented May 1, 2023

azure-pipelines bot commented May 1, 2023

acrolinxatmsft1 commented May 1, 2023

acrolinxatmsft1 commented May 2, 2023

niehaus59 commented May 2, 2023

azure-pipelines bot commented May 2, 2023

acrolinxatmsft1 commented May 2, 2023

acrolinxatmsft1 commented May 3, 2023

niehaus59 commented May 3, 2023

azure-pipelines bot commented May 3, 2023

mhamilton723 left a comment

codecov-commenter commented May 3, 2023 •

edited

Loading

acrolinxatmsft1 commented May 3, 2023

niehaus59 commented May 3, 2023

azure-pipelines bot commented May 3, 2023

acrolinxatmsft1 commented May 25, 2023

chore: conform R-setup.md to reality #1946

chore: conform R-setup.md to reality #1946

Conversation

niehaus59 commented May 1, 2023

Related Issues/PRs

What changes are proposed in this pull request?

How is this patch tested?

Does this PR change any dependencies?

Does this PR add a new feature? If so, have you added samples on website?

acrolinxatmsft1 commented May 1, 2023

Acrolinx Scorecards

github-actions bot commented May 1, 2023

niehaus59 commented May 1, 2023

azure-pipelines bot commented May 1, 2023

acrolinxatmsft1 commented May 1, 2023

Acrolinx Scorecards

acrolinxatmsft1 commented May 2, 2023

Acrolinx Scorecards

niehaus59 commented May 2, 2023

azure-pipelines bot commented May 2, 2023

acrolinxatmsft1 commented May 2, 2023

Acrolinx Scorecards

acrolinxatmsft1 commented May 3, 2023

Acrolinx Scorecards

niehaus59 commented May 3, 2023

azure-pipelines bot commented May 3, 2023

mhamilton723 left a comment

Choose a reason for hiding this comment

codecov-commenter commented May 3, 2023 • edited Loading

Codecov Report

acrolinxatmsft1 commented May 3, 2023

Acrolinx Scorecards

niehaus59 commented May 3, 2023

azure-pipelines bot commented May 3, 2023

acrolinxatmsft1 commented May 25, 2023

Acrolinx Scorecards

codecov-commenter commented May 3, 2023 •

edited

Loading