-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix flakiness in spark installation for r tests #1944
Conversation
/azp run |
Hey @mhamilton723 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1944 +/- ##
==========================================
- Coverage 86.87% 86.84% -0.04%
==========================================
Files 301 301
Lines 15783 15783
Branches 848 848
==========================================
- Hits 13712 13707 -5
- Misses 2071 2076 +5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary by GPT-4
The code snippet provided is a diff file that shows the changes made to the run_r_tests.R
file. The changes include adding three lines of code that install Spark with version 3.2.4 and Hadoop version 3.2.
Here's the updated run_r_tests.R
file after applying the changes:
if (!require("devtools")) {
install.packages("devtools")
}
if (!require("sparklyr")) {
devtools::install_github("rstudio/sparklyr")
}
spark_install(version = "3.2.4", hadoop_version = "3.2")
spark_install(version = "3.2.4", hadoop_version = "3.2")
spark_install(version = "3.2.4", hadoop_version = "3.2")
options("testthat.output_file" = "../../../../r-test-results.xml")
devtools::test(reporter = JunitReporter$new())
However, it seems redundant to have three identical lines for installing Spark with the same version and Hadoop version, so you might want to remove two of them and keep only one:
if (!require("devtools")) {
install.packages("devtools")
}
if (!require("sparklyr")) {
devtools::install_github("rstudio/sparklyr")
}
spark_install(version = "3.2.4", hadoop_version = "3.2")
options("testthat.output_file" = "../../../../r-test-results.xml")
devtools::test(reporter = JunitReporter$new())
Suggestions
No suggestions are needed as the PR has no clear issues.
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentation
folder.Make sure you choose the correct class
estimators/transformers
and namespace.DocTable
points to correct API link.yarn run start
to make sure the website renders correctly.<!--pytest-codeblocks:cont-->
before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTests
job pass in the pipeline.