-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: A base scrubber and a "Shared Access Signature" Scrubber #1939
chore: A base scrubber and a "Shared Access Signature" Scrubber #1939
Conversation
Hey @saileshbaidya 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
/azp run In reply to: 1522368604 |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1939 +/- ##
==========================================
- Coverage 86.87% 86.84% -0.03%
==========================================
Files 301 302 +1
Lines 15783 15786 +3
Branches 848 852 +4
==========================================
- Hits 13712 13710 -2
- Misses 2071 2076 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Minor nits only
core/src/main/scala/com/microsoft/azure/synapse/ml/logging/SynapseMLLogging.scala
Outdated
Show resolved
Hide resolved
/azp run In reply to: 1522686698 |
Azure Pipelines successfully started running 1 pipeline(s). In reply to: 1522686792 |
/azp run In reply to: 1523841003 |
Azure Pipelines successfully started running 1 pipeline(s). In reply to: 1523841245 |
Command 'run
In' is not supported by Azure Pipelines.
See additional documentation. |
2 similar comments
Command 'run
In' is not supported by Azure Pipelines.
See additional documentation. |
Command 'run
In' is not supported by Azure Pipelines.
See additional documentation. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Related Issues/PRs
Task: 2363740
Close #2363740
#xxx
What changes are proposed in this pull request?
Our telemetry system has to avoid logging prohibited information like Shared Access Token, Secrets, etc.
This PR includes a foundational base class for Scrubbers. I am also adding a concrete scrubber SASScrubber to address the latest reported SAS token leaks.
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentation
folder.Make sure you choose the correct class
estimators/transformers
and namespace.DocTable
points to correct API link.yarn run start
to make sure the website renders correctly.<!--pytest-codeblocks:cont-->
before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTests
job pass in the pipeline.