Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retry OnnxHub call to improve test reliability #1889

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

svotaw
Copy link
Collaborator

@svotaw svotaw commented Mar 23, 2023

What changes are proposed in this pull request?

Make OnnxHub more reliable

@github-actions
Copy link

Hey @svotaw 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Merging #1889 (777a83a) into master (412620a) will decrease coverage by 6.94%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1889      +/-   ##
==========================================
- Coverage   86.95%   80.02%   -6.94%     
==========================================
  Files         301      301              
  Lines       15565    15566       +1     
  Branches      797      795       -2     
==========================================
- Hits        13535    12457    -1078     
- Misses       2030     3109    +1079     
Impacted Files Coverage Δ
.../com/microsoft/azure/synapse/ml/onnx/ONNXHub.scala 92.52% <100.00%> (+0.07%) ⬆️

... and 59 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mhamilton723 mhamilton723 merged commit 52919ce into microsoft:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants