New APIs for getting Promise state and result #5131
Conversation
| Js::JavascriptPromise *jsPromise = Js::JavascriptPromise::FromVar(promise); | ||
| Js::JavascriptPromise::PromiseStatus status = jsPromise->GetStatus(); | ||
|
|
||
| switch (status) |
There was a problem hiding this comment.
Should the status be undefined if jsPromise->GetResult() is null here? Just so that we don't return a good status code and then have GetPromiseResult return InvalidArgument- that could be confusing to callers
There was a problem hiding this comment.
A Promise only has a result once it's resolved or rejected, so GetResult() will return nullptr even in the Unresolved case.
lib/Jsrt/ChakraCore.h
Outdated
| @@ -58,6 +58,14 @@ typedef enum JsModuleHostInfoKind | |||
| JsModuleHostInfo_Url = 0x6 | |||
| } JsModuleHostInfoKind; | |||
|
|
|||
| typedef enum JsPromiseStatusCode | |||
| { | |||
| JsPromiseStatusCode_Undefined = 0x00, | |||
There was a problem hiding this comment.
I think we need some documentation on what the difference between JsPromiseStatusCode_Undefined and JsPromiseStatusCode_Unresolved is; can the former ever be returned, or is it just to be used as an initial value?
There was a problem hiding this comment.
I left it in as the default value. I was tempted to leave it out, but I tend to like having an explicit non-value in my enums.
kfarnung
force-pushed
the
promises
branch
2 times, most recently
from
5f0aa71
to
eeeb9f9
Compare
…te and result Merge pull request #5131 from kfarnung:promises
Wiki PR: microsoft/ChakraCore-wiki#54