Enable @@toStringTag by default #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tcare
commented
Aug 3, 2016
•
tcare
commented
- Enabled @@toStringTag by default. Updated baselines.
- Removed the legacy helpers. We only have one special case now; any external object that would have resulted in [object Object] under new rules reverts back to the class name. This retains compat with both DOM and WinRT.
- Fixed the coverage for proxy which was outdated.
- Fixed OS 8331493, a nightly test that was failing.
| @@ -384,8 +384,7 @@ namespace Js | |||
| Var tag = JavascriptOperators::GetProperty(thisArgAsObject, PropertyIds::_symbolToStringTag, scriptContext); // Let tag be the result of Get(O, @@toStringTag). | |||
|
|
|||
| // 17. Return the String that is the result of concatenating "[object ", tag, and "]". | |||
| if (tag != nullptr && JavascriptString::Is(tag)) | |||
| { | |||
| auto buildToString = [&scriptContext](Var tag) { | |||
There was a problem hiding this comment.
curious what's the expected output of Object.getOwnPropertyNames(Math)? should we have Symbol.toString output as well?
nit: add this text to the PR description so it will be automatically included in the merge commit description. |
|
Looks good to me - it would be be good to remove -tostringtag flag from the rlexe.xml (makes the xml cleaner and when we get rid of this flag completely it will be easy transition). #Resolved |
|
Sounds good. |
|
|
chakrabot
pushed a commit
that referenced
this pull request
Aug 5, 2016
Merge pull request #1383 from tcare:tostringtag - Enabled @@toStringTag by default. Updated baselines. - Removed the legacy helpers. We only have one special case now; any external object that would have resulted in [object Object] under new rules reverts back to the class name. This retains compat with both DOM and WinRT. - Fixed the coverage for proxy which was outdated. - Fixed OS 8331493, a nightly test that was failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.