JSRT module api #1254

Yongqu · 2016-07-08T00:00:17Z

Add module support in chakracore by adding related JSRT APIs. This set of
APIs are in chakracore.dll only, not in chakra.dll as we are using different binding
for edge browser. The host is responsible for asynchronously fetch dependent modules
and handle error conditions.

The overall loading sequences:

   host                                chakacore.dll
1. Load top level script
2.                             ---->   JsInitializeModuleRecord // for root module
3.                             ---->   JsParseModuleSource      // parse root module
4. FetchImportedModuleCallback <----                            // optional for imported module
5.                             ----->  JsInitializeModuleRecord // for nested module
6. load additional script
7.                             ----->  JsParseModuleSource      // for nested module
8. NotifyModuleReadyCallback   <-----
9.                             ----->  JsModuleEvaluation       // for root module

step 4 to step 7 could be happening in a loop, and step 5 should happen asynchronously
like in a Promise. Step 9 will also evaluate all the nested modules.

Port some existing test cases to ch. We need to support test262 hook in later checkin.

Add module support in chakracore by adding related JSRT APIs. This set of APIs are in chakracore.dll only, not in chakra.dll as we are using different binding for edge browser. The host is responsible for asynchronously fetch dependent modules and handle error conditions. The overall loading sequences: host chakacore.dll 1. Load top level script 2. ----> JsInitializeModuleRecord // for root module 3. ----> JsParseModuleSource // parse root module 4. FetchImportedModuleCallback <---- // optional for imported module 5. -----> JsInitializeModuleRecord // for nested module 6. load additional script 7. -----> JsParseModuleSource // for nested module 8. NotifyModuleReadyCallback <----- 9. -----> JsModuleEvaluation // for root module step 4 to step 7 could be happening in a loop, and step 5 should happen asynchronously like in a Promise. Step 9 will also evaluate all the nested modules. Port some existing test cases to ch. We need to support test262 hook in later checkin.

Yongqu · 2016-07-08T00:01:47Z

@boingoing can you take a look?

akroshg · 2016-07-08T01:28:59Z

bin/ChakraCore/ChakraCore.def

+JsParseModuleSource
+JsModuleEvaluation
+JsSetModuleHostInfo
+JsGetModuleHostInfo


you should consider adding nativetests for these sets of api. nativetests should be the place for adding negative tests to validate the various inputs for these APIs which ch.exe is not supposed to do.

good point; will leave out of this change though.

Added this issue to track this #1269

dilijev · 2016-07-08T22:25:56Z

lib/Jsrt/ChakraCore.h

+/// </remarks>
+/// <param name="referencingModule">The referencingModule as in HostResolveImportedModule (15.2.1.17). nullptr if this is the top level module.</param>
+/// <param name="normalizedSpecifier">The host normalized specifier. This is the key to a unique ModuleRecord.</param>
+/// <param name="specifierLength">The length of normalizedSpecifier.</param>


There is no parameter named specifierLength #Resolved

Disable module tests in linux for now while I figure out why the import entries don't get resolved correctly in ch.

boingoing · 2016-07-12T01:01:52Z

bin/ch/stdafx.h

@@ -25,6 +25,9 @@

 #define ENABLE_TEST_HOOKS 1
 #include "CommonDefines.h"
+#include <map>
+
+#include <map>


Looks like is included twice here.

yeah merge resolution error. Will fix it with the Linux static build failure. #Resolved

Yongqu · 2016-07-14T22:30:16Z

@boingoing any additional feedback?

dilijev · 2016-07-14T22:54:15Z

LGTM

Merge pull request #1254 from Yongqu:bugfix Add module support in chakracore by adding related JSRT APIs. This set of APIs are in chakracore.dll only, not in chakra.dll as we are using different binding for edge browser. The host is responsible for asynchronously fetch dependent modules and handle error conditions. The overall loading sequences: ``` host chakacore.dll 1. Load top level script 2. ----> JsInitializeModuleRecord // for root module 3. ----> JsParseModuleSource // parse root module 4. FetchImportedModuleCallback <---- // optional for imported module 5. -----> JsInitializeModuleRecord // for nested module 6. load additional script 7. -----> JsParseModuleSource // for nested module 8. NotifyModuleReadyCallback <----- 9. -----> JsModuleEvaluation // for root module ``` step 4 to step 7 could be happening in a loop, and step 5 should happen asynchronously like in a Promise. Step 9 will also evaluate all the nested modules. Port some existing test cases to ch. We need to support test262 hook in later checkin.

JohnMasen · 2017-12-22T03:25:54Z

hi,
I'm working on a library which porting the chakracore to dotnetcore (Chakracore.NET on Github). I have trouble porting the module support part.
here's the question:
what does "1. Load top level script " mean? I'm using JsRunScript to execute the script. does the "Load" means "serialize the script"? I can barely read the C++ source code as I have no C++ experience. loading module is the last piece of my library, can any one help?

obastemur · 2017-12-22T03:33:05Z

@JohnMasen I’m afraid the message you have sent here is going to be lost. Can you please open an issue?

msftclas added the cla-not-required label Jul 8, 2016

akroshg reviewed Jul 8, 2016
View reviewed changes

Yongqu added 2 commits July 8, 2016 08:17

review feedback

b3bec21

Merge branch 'master' into bugfix

bfeace1

dilijev reviewed Jul 8, 2016
View reviewed changes

Yongqu and others added 4 commits July 8, 2016 21:27

code review feedback; pass in linux

28f2bb1

Disable module tests in linux for now while I figure out why the import entries don't get resolved correctly in ch.

revert earlier change

42cac2f

review feedback; linux fix

f84e214

remove useless entry in chakrartinterface.h

09a04ef

boingoing reviewed Jul 12, 2016
View reviewed changes

dilijev mentioned this pull request Jul 12, 2016

Add native tests for new JSRT APIs #1269

Closed

Yongqu added 2 commits July 14, 2016 10:51

Merge branch 'master' into bugfix

1bdeac4

fix earlier merge conflict resolution error

baca8a4

chakrabot merged commit baca8a4 into chakra-core:master Jul 14, 2016

liminzhu mentioned this pull request Apr 27, 2017

Enable beta features microsoft/Chakra-Samples#77

Closed

dilijev mentioned this pull request Nov 21, 2017

Add JSRT basic tasks tutorials microsoft/ChakraCore-wiki#44

Merged

JohnMasen mentioned this pull request Dec 22, 2017

[Clarify request] Question about support module loading in host #4472

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JSRT module api #1254

JSRT module api #1254

Yongqu commented Jul 8, 2016 •

edited by dilijev

Loading

Yongqu commented Jul 8, 2016

akroshg Jul 8, 2016

Yongqu Jul 8, 2016

dilijev Jul 12, 2016 •

edited

Loading

dilijev Jul 8, 2016 •

edited by Yongqu

Loading

boingoing Jul 12, 2016

Yongqu Jul 12, 2016

Yongqu commented Jul 14, 2016

dilijev commented Jul 14, 2016

JohnMasen commented Dec 22, 2017

obastemur commented Dec 22, 2017

JSRT module api #1254

JSRT module api #1254

Conversation

Yongqu commented Jul 8, 2016 • edited by dilijev Loading

Yongqu commented Jul 8, 2016

akroshg Jul 8, 2016

Choose a reason for hiding this comment

Yongqu Jul 8, 2016

Choose a reason for hiding this comment

dilijev Jul 12, 2016 • edited Loading

Choose a reason for hiding this comment

dilijev Jul 8, 2016 • edited by Yongqu Loading

Choose a reason for hiding this comment

boingoing Jul 12, 2016

Choose a reason for hiding this comment

Yongqu Jul 12, 2016

Choose a reason for hiding this comment

Yongqu commented Jul 14, 2016

dilijev commented Jul 14, 2016

JohnMasen commented Dec 22, 2017

obastemur commented Dec 22, 2017

Yongqu commented Jul 8, 2016 •

edited by dilijev

Loading

dilijev Jul 12, 2016 •

edited

Loading

dilijev Jul 8, 2016 •

edited by Yongqu

Loading