Skip to content
This repository has been archived by the owner on Jul 5, 2020. It is now read-only.

Stripping port from target breaks Application Map for reverse proxy scenarios #1121

Closed
zakimaksyutov opened this issue Nov 30, 2018 · 3 comments
Closed

Stripping port from target breaks Application Map for reverse proxy scenarios #1121

zakimaksyutov opened this issue Nov 30, 2018 · 3 comments
Assignees
@lmolkova
Labels
enhancement
Milestone
2.9

Comments

@zakimaksyutov
Copy link
Member

AI SDK strips port from target field. This breaks reverse proxy scenarios which differentiate which app to forward to by using a port.

Should we consider keeping a port in target?
@lmolkova lmolkova self-assigned this Nov 30, 2018
@lmolkova lmolkova added this to the 2.9 milestone Nov 30, 2018
@SergeyKanzhelev
Copy link
Contributor

Is it a reoccurance of #285?

@zakimaksyutov
Copy link
Member Author

It says that it is fixed in 2.3. Looks like it regressed at some point. Or maybe this logic doesn't work only for localhost targets.

@lmolkova lmolkova mentioned this issue Dec 1, 2018
Merged
5 tasks
@lmolkova
Copy link
Member

lmolkova commented Dec 1, 2018

this logic does not work for .net core only.

@lmolkova lmolkova closed this as completed Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lmolkova lmolkova

Labels
enhancement
Projects
None yet
Milestone
2.9
Development

No branches or pull requests
3 participants
@lmolkova @SergeyKanzhelev @zakimaksyutov