-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NotInSummary wrongly reported if -f
option is used
#86
Comments
cc #77 |
camelid
added a commit
to xFrednet/rustc-dev-guide
that referenced
this issue
Aug 6, 2024
See Michael-F-Bryan/mdbook-linkcheck#77 and Michael-F-Bryan/mdbook-linkcheck#86. These bugs are causing linkcheck to erroneously fail because we run it using `-f`, to avoid too many requests. For now, disable linkcheck in PR CI, though leave it enabled in the cron job, where the bug should not occur.
camelid
added a commit
to rust-lang/rustc-dev-guide
that referenced
this issue
Aug 8, 2024
See Michael-F-Bryan/mdbook-linkcheck#77 and Michael-F-Bryan/mdbook-linkcheck#86. These bugs are causing linkcheck to erroneously fail because we run it using `-f`, to avoid too many requests. For now, disable linkcheck in PR CI, though leave it enabled in the cron job, where the bug should not occur.
marxin
added a commit
to marxin/mdbook-linkcheck
that referenced
this issue
Aug 8, 2024
marxin
added a commit
to marxin/mdbook-linkcheck
that referenced
this issue
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that while debugging the https://rustc-dev-guide.rust-lang.org/ documentation that utilizes
-f
option for files modified against the master branch.The problematic invocation:
The problem is that
llvm-coverage-instrumentation.md
is not included infile_names
(contains only the filtered file) passed as argument toensure_included_in_book
. And thus the warning is triggered.The text was updated successfully, but these errors were encountered: