Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attribute names should not be quoted unconditionally #181

Closed
natsukium opened this issue Aug 6, 2023 · 1 comment · Fixed by #182
Closed

attribute names should not be quoted unconditionally #181

natsukium opened this issue Aug 6, 2023 · 1 comment · Fixed by #182

Comments

@natsukium
Copy link
Contributor

The PRs associated with #178 added the escaping of attribute names.
Because of this, it is impossible to evaluate packages with namespaces such as python3Packages in nixpkgs.

$ nix run github:Mic92/nix-update/0.19.2#nix-update -- python310Packages.streamlit

...
error: attribute '"python310Packages.streamlit"' missing

       at «string»:8:9:

            7|            (if args ? overlays then { overlays = [ ]; } else {});
            8|   pkg = (pkgs inputs)."python310Packages.streamlit";
             |         ^
            9|   sanitizePosition = x: x;
Traceback (most recent call last):
...

Really, we could just do this unconditionally, since there isn't any real difference between x.y and x."y" other than variable interpolation?

This is precisely the problem. Quoting them prevents expanding the namespace.

@figsoda
Copy link
Collaborator

figsoda commented Aug 6, 2023

oops, I didn't think about that

#182 should be able to fix this, sorry about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants