[Meta Issue] Write tests for codebase

[tylerpotts]

Summary

All functions need tests to ensure they do what we expect and to catch bugs before they get into the main branch. The tests should cover all known cases and potential bugs. If new bugs appear, new tests should be written to cover the new bug.

We should generally follow the suggested rules of testing given here:
https://docs.python-guide.org/writing/tests/

This issue covers everything except cli.py, which we will work on next.

Proposed implementation

• This is a meta issue (aka Epic), so a new issue should be opened for each task. Some tasks are in the list below, but other tasks can be added to this meta issue by editing this description.
• There are data files in the tests directory that can be used in the tests. Do not modify the data files.
• All tests should be in the tests directory.
• Each module in the repo will have a test file named tests_{module name}.py
• Each test will be a function named test_{some function}.py

Acceptance Criteria

• All functions and methods (except in cli.py) have tests (full coverage)

Tasks to complete

Tests should be written for each function:

• https://github.com/metrostar/ib_manifest_util/blob/main/ib_manifest_util/update_repository.py#L16 Make tests for update_repository #18
• https://github.com/metrostar/ib_manifest_util/blob/main/ib_manifest_util/create_dockerfile.py#L9
• https://github.com/metrostar/ib_manifest_util/blob/main/ib_manifest_util/create_dockerfile.py#L63
• https://github.com/metrostar/ib_manifest_util/blob/main/ib_manifest_util/create_hardening_manifest.py#L15
• https://github.com/metrostar/ib_manifest_util/blob/main/ib_manifest_util/download_conda_packages.py#L7 Make tests for download_packages #6
• https://github.com/metrostar/ib_manifest_util/blob/main/ib_manifest_util/util.py#L18 Improve tests for write_templatized_file #5
• https://github.com/metrostar/ib_manifest_util/blob/main/ib_manifest_util/util.py#L42
• https://github.com/metrostar/ib_manifest_util/blob/main/ib_manifest_util/util.py#L68 Make test for run_subprocess #16
• https://github.com/metrostar/ib_manifest_util/blob/main/ib_manifest_util/util.py#L78 tests for download_file #12
• dump_yaml function initial commit for dump and dump test #15

Related to

[kcpevey]

Check here for coverage

[kcpevey]

Check here for coverage