Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_request_duration_seconds reports milliseconds #40

Closed
Informatic opened this issue May 18, 2022 · 1 comment
Closed

http_request_duration_seconds reports milliseconds #40

Informatic opened this issue May 18, 2022 · 1 comment

Comments

@Informatic
Copy link

Hey!
This produces values in milliseconds:
https://github.com/MetinSeylan/Nestjs-OpenTelemetry/blob/main/src/Metric/Interceptors/Http/MetricHttpEventProducer.ts#L20-L21

Besides wrong metric name, default buckets configuration ([0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10]) also makes this metric unusable.

I think seconds is a commonly accepted unit for request duration histograms, so that value should probably be adjusted accordingly.

@MetinSeylan
Copy link
Owner

#49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants