Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cmdlet Update-VSTeamAgent #278

Closed
SebastianSchuetze opened this issue Mar 10, 2020 · 4 comments
Closed

Improve cmdlet Update-VSTeamAgent #278

SebastianSchuetze opened this issue Mar 10, 2020 · 4 comments
Assignees
@DarqueWarrior
Labels
enhancement Improvements that do not include new features

Comments

@SebastianSchuetze
Copy link
Collaborator

SebastianSchuetze commented Mar 10, 2020 •
edited
Loading

As discussed earlier with @DarqueWarrior the PR #273 is good, but some changes should be improved:

  • command should be renamed to Update-VSTeamAgentSoftware
  • also by default the cmdlet should give a warning as it does on the UI (see screenshot below). This means the SupportsShouldProcess should be added to the function so the -force flag has to be used to deactivate the confirmation manually
  • the related unit tests should be moved to an extra file named Update-VSTeamAgentSoftware.Tests.ps1

image
@SebastianSchuetze SebastianSchuetze added the enhancement Improvements that do not include new features label Mar 10, 2020
@SebastianSchuetze SebastianSchuetze mentioned this issue Mar 10, 2020
Merged
3 tasks
@DarqueWarrior DarqueWarrior self-assigned this Mar 10, 2020
@DarqueWarrior
Copy link
Collaborator

I will take care of this today.

@woehrl01
Copy link
Contributor

Great improvement ideas! If you need help, just raise your hand.

@DarqueWarrior
Copy link
Collaborator

Thanks for the PR @woehrl01 I really appreciate the support. The changes are making their way through the pipeline now. Hope to have a new release soon.

@SebastianSchuetze
Copy link
Collaborator Author

This is done with one of the last releases, although we left the cmdlet name as it is. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarqueWarrior DarqueWarrior

Labels
enhancement Improvements that do not include new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@woehrl01 @DarqueWarrior @SebastianSchuetze