Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on premise :( #11

Closed
aneillans opened this issue Jul 28, 2017 · 4 comments
Closed

Broken on premise :( #11

aneillans opened this issue Jul 28, 2017 · 4 comments

Comments

@aneillans
Copy link
Contributor

Unfortunately #10 breaks on premise usage of the module. Need to consider a different way for identifying whether the user has entered a FQDN (i.e. local) TFS server, or means a VSTS account.
Ironically, possibly the best method would be just looking for a slash (/) as this wouldn't be in an account name, but would be guaranteed to be present in an on-premise url.

Thoughts?

@aneillans
Copy link
Contributor Author

"Fix" for it in #12 I'm not happy with the fix, its hacky, but it works. Needs more thought I think.

@DarqueWarrior
Copy link
Collaborator

Do you still have concerns about this fix?

@aneillans
Copy link
Contributor Author

aneillans commented Sep 20, 2017 via email

@DarqueWarrior
Copy link
Collaborator

Feel free to submit a PR for a better fix. I have not had any issues so I am going to close this. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants