-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken on premise :( #11
Comments
"Fix" for it in #12 I'm not happy with the fix, its hacky, but it works. Needs more thought I think. |
Do you still have concerns about this fix? |
Yeah, but it generally works. It definitely has a smell about it.
…Sent from my iPhone
On 20 Sep 2017, at 18:06, Donovan Brown ***@***.***> wrote:
Do you still have concerns about this fix?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Feel free to submit a PR for a better fix. I have not had any issues so I am going to close this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Unfortunately #10 breaks on premise usage of the module. Need to consider a different way for identifying whether the user has entered a FQDN (i.e. local) TFS server, or means a VSTS account.
Ironically, possibly the best method would be just looking for a slash (/) as this wouldn't be in an account name, but would be guaranteed to be present in an on-premise url.
Thoughts?
The text was updated successfully, but these errors were encountered: