-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bumping to latest #375
base: master
Are you sure you want to change the base?
Conversation
Instructions to fix image issue in meteor 1.8.1
fix(version bumping): changes according to node apn and GCM pacakge
…mentation-updates
Updated versions to latest
Changed package dependency names for atmosphere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed - works as expected, will break previous implementations that don't update before using new version. Please make sure README is updated.
@@ -1,19 +1,19 @@ | |||
Package.describe({ | |||
name: 'raix:push', | |||
version: '0.0.0-semantic-release', | |||
name: 'shivangkar:push', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this PR to be merged, this needs to be changed back to raix:push
summary: 'Isomorphic Push notifications for APN and GCM', | ||
git: 'https://github.com/raix/push.git' | ||
git: 'https://github.com/shivang007/push.git' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to point to this repository.
It contains breaking changes for APN option users.