Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bumping to latest #375

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

MrSpark2591
Copy link

It contains breaking changes for APN option users.

Copy link
Collaborator

@dennisharrison dennisharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed - works as expected, will break previous implementations that don't update before using new version. Please make sure README is updated.

@@ -1,19 +1,19 @@
Package.describe({
name: 'raix:push',
version: '0.0.0-semantic-release',
name: 'shivangkar:push',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this PR to be merged, this needs to be changed back to raix:push

summary: 'Isomorphic Push notifications for APN and GCM',
git: 'https://github.com/raix/push.git'
git: 'https://github.com/shivang007/push.git'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to point to this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants