Connect flags #202
Merged
Connect flags #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@modolol: I'll merge this PR early next week I think. It fixes flags and some plots. |
|
Merging this to have all the "valid" changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces several improvements related to flags. First, these now propagate through the
process_chunk(),weighted_mean()anddelta()functions. Specifically, flags are being combined (bitwise OR) when their associated data points are being combined (in whatever way). Namely, the average of a flagged and un-flagged points will be flagged.This PR also introduces the possibility to crop descent data during the basic cleanup recipe step of the uaii2022, and fixes a few minor things.
This PR also introduces a new recipe step dedicated to generating the CWS-validation plots (
gdp_vs_cwsanduc_budget). These now have 3 x-axis (i, tdt, alt), which are all computed "properly". The alt, in particular, is taken as the CWS ref_alt, which itself, is generated from the CWS gph with holes interpolated and outer gaps filled with -99999 and +99999 to easily identify those bad regions (doing so is required to allow back-and-forth interpolation by matplotlib - NaNs are unsuitable).Error(s) fixed:
Fix #163.
Checklists: