Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'tdt' of CWS requires a proper computation of the start time #163

Closed
fpavogt opened this issue Jul 16, 2021 · 2 comments · Fixed by #202
Closed

'tdt' of CWS requires a proper computation of the start time #163

fpavogt opened this issue Jul 16, 2021 · 2 comments · Fixed by #202
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@fpavogt
Copy link
Member

fpavogt commented Jul 16, 2021

Describe the bug
Up to now, the time array of the combined working standard were computed via the weighted average routine. In #162, a dedicated time array for the CWS has been put in place - for now, simply starting at 0 on the first step.

What is required, however, is to decide which step corresponds to the rig launch time. And for that, there is currently no routines in dvas.

@GonzagueRomanens : I'd be keen to talk to you about this at some point. Right now, I'm leaning towards using the GRUAN established launch times. These are present in the RS-41 GDPs ... to be seen if they get included in other GDPs ?

@fpavogt fpavogt added bug Something isn't working enhancement New feature or request labels Jul 16, 2021
@fpavogt fpavogt added this to the v0.5.0 milestone Jul 16, 2021
@fpavogt fpavogt self-assigned this Jul 16, 2021
@fpavogt
Copy link
Member Author

fpavogt commented Mar 17, 2022

Hey @cfelix-ch, adding the cws_alt to the GDP plots requires (in part) to fix this issue.

If you and @GonzagueRomanens agree, I propose to adopt an "all-or-nothing" startegy here as well: namely, I will take the launch time to be the latest one among the GDPs. Essentially, this means that the CWS will "launch" when all three GDPs say they have launched.

@fpavogt
Copy link
Member Author

fpavogt commented Mar 18, 2022

After discussion with @GonzagueRomanens, we'll set the tdt=0 of the CWS as soon as 1 GDP says the flight started. This is the safest approach.

@fpavogt fpavogt mentioned this issue Mar 18, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant