Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validator ought to issue critical warnings when versionString in version pragma doesn't match parsed version printString #179

Open
GoogleCodeExporter opened this issue Mar 24, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

In a nutshell, when a version is specified as follows

  <version: '4.04' imports: #('4.2-baseline' )> 

the following is NOT true:

 '4.04' asMetacelloVersionNumber versionString = '4.04'

instead 

  '4.04' asMetacelloVersionNumber versionString

returns '4-04'. This is worth a critical warning at minimum!

for more details see:

  http://groups.google.com/group/metacello/msg/eb5b5a2af58c7141

Original issue reported on code.google.com by [email protected] on 28 Feb 2012 at 12:42

@GoogleCodeExporter
Copy link
Author

The "correct" version string would be '4.4' as Metacello sorts numeric values 
correctly and leading '0' is not needed. The leading '0' is only needed as a 
place holder if versions sorted as strings... 

Original comment by [email protected] on 28 Feb 2012 at 12:44

  • Changed title: validator ought to issue critical warnings when versionString in version pragma doesn't match parsed version printString
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 19 May 2012 at 7:41

  • Added labels: Milestone-1.0-beta.31.2
  • Removed labels: Milestone-1.0-beta.31.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant