Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Keyring serialize and deserialize type signature #128

Open
Gudahtt opened this issue Aug 4, 2023 · 0 comments
Open

Fix Keyring serialize and deserialize type signature #128

Gudahtt opened this issue Aug 4, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Aug 4, 2023

The type for the keyring deserialize and serialize methods wrongly state that the full keyring state is expected. The deserialize method should accept the serialized state, which is not the same as the keyring state. We should update these methods to expect unknown as the state type.

@Gudahtt Gudahtt added the bug Something isn't working label Aug 4, 2023
@Gudahtt Gudahtt changed the title Fix Keyring deserialize type signature Fix Keyring serialize and deserialize type signature Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant