Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ethjs signing method #72

Open
rekmarks opened this issue Jul 23, 2020 · 2 comments
Open

Add ethjs signing method #72

rekmarks opened this issue Jul 23, 2020 · 2 comments

Comments

@rekmarks
Copy link
Member

Per: https://github.com/danfinlay/js-eth-personal-sign-examples
@danjm
Copy link
Contributor

danjm commented Oct 4, 2021

@rekmarks I believe this has been resolved? All the relevant methods seem to be here: https://metamask.github.io/test-dapp/

@digiwand
Copy link
Contributor

Looks like all signing methods were added to the test-dapp except for the Ethjs signing method

https://github.com/ethjs/ethjs
https://github.com/danfinlay/js-eth-personal-sign-examples/blob/master/index.js#L399

updating the ticket to address this one

@digiwand digiwand changed the title Add all available signing methods Add ethjs signing method Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danjm @digiwand @rekmarks