Add name lookup example snap #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
requested changes
Sep 21, 2023
packages/test-snaps/src/features/snaps/name-lookup/NameLookup.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1768 +/- ##
==========================================
+ Coverage 95.79% 95.82% +0.02%
==========================================
Files 240 239 -1
Lines 5476 5464 -12
Branches 852 851 -1
==========================================
- Hits 5246 5236 -10
+ Misses 230 228 -2
☔ View full report in Codecov by Sentry. |
Update example readme. Fix changelog. Add Jest config. Fix package scripts. Use updated config file. Add JSDoc.
Mrtenz
reviewed
Sep 21, 2023
Co-authored-by: Maarten Zuidhoorn <[email protected]>
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Mrtenz
previously approved these changes
Sep 21, 2023
|
@SocketSecurity ignore @esbuild-plugins/[email protected] |
Mrtenz
approved these changes
Sep 21, 2023
hmalik88
added a commit
that referenced
this pull request
Oct 11, 2023
The current example snap is not inline with SIP-12, see #1768 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
Name Lookup Example Snapto support manual and E2E testing with thename-lookuphandler and endowment.Supports resolving both domains and addresses based on the request.
If an address is provided, it returns static text followed by a shortened form of the address and the hex form of the chain ID, in order to provide some validation of the received arguments. e.g.
example.domain - 0xCD2 / 0x5If a domain is provided, it simply returns a static Ethereum address:
0xc0ffee254729296a45a3885639AC7E10F9d54979If neither values are provided, it returns
null.No additional UI is included in the
test-snapspackage beyond the standardConnectbutton.