Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new yarn.lock for update pull request workflow #1740

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Sep 12, 2023

yarn dedupe can change the lockfile, which can change the result of the other two jobs in the workflow. To solve this, the dedupe step is run first, and when that is finished, the other two jobs are run, using the new lockfile.

@Mrtenz Mrtenz requested a review from a team as a code owner September 12, 2023 07:59
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0c52d61) 95.74% compared to head (bd87ba8) 95.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1740   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files         239      239           
  Lines        5410     5410           
  Branches      837      837           
=======================================
  Hits         5180     5180           
  Misses        230      230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz merged commit 8739bbf into main Sep 12, 2023
131 checks passed
@Mrtenz Mrtenz deleted the mrtenz/update-update-pull-request branch September 12, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants