Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(snaps-utils): Explicit type for CronjobRpcRequestStruct #1706

Closed

Conversation

legobeat
Copy link
Contributor

This makes the type generated from superstruct explicit. Lifted from dist.

@legobeat legobeat force-pushed the types-utils-explicit-superstruct branch from babcfd4 to 9a8bce9 Compare August 30, 2023 01:27
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.02% ⚠️

Comparison is base (a596bee) 95.87% compared to head (cd71d97) 95.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1706      +/-   ##
==========================================
- Coverage   95.87%   95.85%   -0.02%     
==========================================
  Files         239      239              
  Lines        5401     5402       +1     
  Branches      836      836              
==========================================
  Hits         5178     5178              
- Misses        223      224       +1     
Files Changed Coverage Δ
packages/snaps-utils/src/cronjob.ts 96.55% <50.00%> (-3.45%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the types-utils-explicit-superstruct branch from 9a8bce9 to cd71d97 Compare August 30, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants