Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump WebdriverIO #1702

Merged
merged 14 commits into from
Aug 30, 2023
Merged

Bump WebdriverIO #1702

merged 14 commits into from
Aug 30, 2023

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Aug 29, 2023

Bumps all WebdriverIO packages to latest including esbuild. Also bumps puppeteer for deduping reasons.

This PR includes a few patches, one to fix an issue that is yet to be fixed in WebdriverIO and one to fix a compatibility problem with jest-util.

This PR also pins @types/node to a specific v18 version to prevent type issues with streams. This should be investigated and fixed in the future.

Lastly this PR bumps chromedriver and the version of Chrome we use for E2E tests.

Hopefully this improves flakyness of E2E tests as WebdriverIO has had multiple updates that may alleviate our problems.

@socket-security
Copy link

socket-security bot commented Aug 29, 2023

@socket-security
Copy link

socket-security bot commented Aug 29, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], @tootallnate/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

ownership changes ok

@FrederikBolding
Copy link
Member Author

@metamaskbot update-pr

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1d14bcb) 95.87% compared to head (e0b5454) 95.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1702   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files         239      239           
  Lines        5409     5409           
  Branches      836      836           
=======================================
  Hits         5186     5186           
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding
Copy link
Member Author

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

FS access ok

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

Required by geckodriver

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore @tootallnate/[email protected]

Network access ok

@FrederikBolding FrederikBolding changed the title Bump WebDriverIO to try to fix test flakyness Bump WebdriverIO Aug 30, 2023
@FrederikBolding FrederikBolding marked this pull request as ready for review August 30, 2023 12:28
@FrederikBolding FrederikBolding requested a review from a team as a code owner August 30, 2023 12:28
Mrtenz
Mrtenz previously approved these changes Aug 30, 2023
@FrederikBolding
Copy link
Member Author

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

Network access ok

@SocketSecurity ignore [email protected]

Required by geckodriver

@SocketSecurity ignore [email protected]

Used by wdio to track down browsers

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

"Unmaintained" packages, they look fine though and are used in dep trees of widely used packages.

@FrederikBolding
Copy link
Member Author

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

Required by geckodriver or otherwise used in widely used packages.

@FrederikBolding FrederikBolding merged commit 4dfcc60 into main Aug 30, 2023
129 checks passed
@FrederikBolding FrederikBolding deleted the fb/bump-wdio branch August 30, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants