-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harden all endowments #585
Comments
Hey team! Please add your planning poker estimate with Zenhub @david0xd @FrederikBolding @GuillaumeRx @hmalik88 @Mrtenz @ritave |
Note from standup: This should be done prior to any external audits. Date to be determined. |
It is found that the Jest test framework does not work with SES. That makes impossible to test code that includes SES functions such as Research of the potential test framework that can be used with SES is followed up in another ticket here: #1003 |
Additional work in this epic to be defined after initial investigation in https://app.zenhub.com/workspaces/snaps-platform-615b3a7c08d2b20015eb6c4e/issues/metamask/snaps-monorepo/1003 |
To the greatest extent possible, endowment made available to a snap should be hardened via SES's
harden()
function. This is to preclude the existence of sandbox escapes by e.g. walking properties to obtain a reference to the root realmglobalThis
.This effort is complicated by the existence of endowments that may depend on mutable properties, for example the
wallet
provider object.For all of the endowments we pass to snaps, we should:
harden()
.harden()
, and take whatever other measures may be necessary to close unsanctioned communications channels with the root realm.The text was updated successfully, but these errors were encountered: