Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with doing instanceof checks to fetch responses #2891

Closed
FrederikBolding opened this issue Nov 15, 2024 · 0 comments · Fixed by #2889
Closed

Fix issues with doing instanceof checks to fetch responses #2891

FrederikBolding opened this issue Nov 15, 2024 · 0 comments · Fixed by #2889
Assignees
@FrederikBolding

Comments

@FrederikBolding
Copy link
Member

No description provided.

@FrederikBolding FrederikBolding self-assigned this Nov 15, 2024
@FrederikBolding FrederikBolding mentioned this issue Nov 19, 2024
Merged
FrederikBolding added a commit that referenced this issue Nov 19, 2024
@FrederikBolding
fix: Make ResponseWrapper an instance of Response (#2889)
96a29cb 
Overwrite `[Symbol.hasInstance]` on the exposed `Response` class
slightly to make `ResponseWrapper` pass `instanceof` checks. This
prevents `fetch` responses from failing when using WASM bindgen for
instance.

Fixes #2891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrederikBolding FrederikBolding

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Make ResponseWrapper an instance of Response MetaMask/snaps
1 participant
@FrederikBolding