Re-introduce expanded view notifications via snap_notify
#2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2881 +/- ##
=======================================
Coverage 94.48% 94.49%
=======================================
Files 487 487
Lines 10428 10442 +14
Branches 1598 1600 +2
=======================================
+ Hits 9853 9867 +14
Misses 575 575 ☔ View full report in Codecov by Sentry. |
Mrtenz
previously requested changes
Nov 12, 2024
hmalik88
changed the title
snap_notifysnap_notify
|
Is there an extension PR where this has been integrated? |
|
hmalik88
changed the title
snap_notifysnap_notify
FrederikBolding
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverses the revert that was made to previous
snap_notifychanges that enabled an expanded view for snap notifications (see #2706). Additional adjustments were made for including the content type of the interface being created in thesnap_notifycall. These changes are being introduced post-introduction of interface persistence in theSnapInterfaceController(see #2856), which without, the expanded view feature was broken.