Add image component #1783
Merged
Add image component #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1783 +/- ##
=======================================
Coverage 95.92% 95.93%
=======================================
Files 239 239
Lines 5494 5504 +10
Branches 858 860 +2
=======================================
+ Hits 5270 5280 +10
Misses 224 224
☔ View full report in Codecov by Sentry. |
|
@metamaskbot update-pr |
1 similar comment
|
@metamaskbot update-pr |
FrederikBolding
force-pushed
the
fb/custom-ui-image
branch
from
2f1f7a9 to
c9147f3
Compare
|
@metamaskbot update-pr |
Mrtenz
requested changes
Oct 4, 2023
|
@metamaskbot update-pr |
Mrtenz
previously approved these changes
Oct 4, 2023
FrederikBolding
force-pushed
the
fb/custom-ui-image
branch
from
61f05f9 to
155b46a
Compare
Mrtenz
previously approved these changes
Oct 4, 2023
|
@metamaskbot update-pr |
Mrtenz
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add image component for showing images as part of snaps custom UI. Also adds support for this feature in the snaps simulator. This PR will need follow-up work in the extension.
Progresses https://github.com/MetaMask/MetaMask-planning/issues/1345