Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where errors would not correctly be returned #1772

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Sep 21, 2023

Fixes an issue where errors thrown inside the snap would not be correctly returned because they weren't JSON serializable. Instead, the JSON-RPC request would get no response and stall until it was timed out.

This was fixed by changing the pattern used to return errors when a response value is not valid JSON.

@FrederikBolding FrederikBolding marked this pull request as ready for review September 22, 2023 07:28
@FrederikBolding FrederikBolding requested a review from a team as a code owner September 22, 2023 07:28
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (f865a28) 95.82% compared to head (db74c3c) 95.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1772      +/-   ##
==========================================
+ Coverage   95.82%   95.84%   +0.01%     
==========================================
  Files         239      239              
  Lines        5464     5465       +1     
  Branches      851      851              
==========================================
+ Hits         5236     5238       +2     
+ Misses        228      227       -1     
Files Changed Coverage Δ
...cution-environments/src/common/BaseSnapExecutor.ts 89.18% <100.00%> (+0.75%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 080d211 into main Sep 22, 2023
134 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-error-not-being-returned branch September 22, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants