Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pump #1730

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Remove pump #1730

merged 5 commits into from
Sep 11, 2023

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Sep 7, 2023

Removes pump in favor of pipeline, which should do the same thing.

One difference is that pipeline requires a callback to specified, therefore a few extra callbacks have been introduced, mainly for error logging.

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @types/[email protected]

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 63.15% and project coverage change: -0.13% ⚠️

Comparison is base (c5ddd89) 95.87% compared to head (7ff617b) 95.74%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1730      +/-   ##
==========================================
- Coverage   95.87%   95.74%   -0.13%     
==========================================
  Files         239      239              
  Lines        5405     5410       +5     
  Branches      835      837       +2     
==========================================
- Hits         5182     5180       -2     
- Misses        223      230       +7     
Files Changed Coverage Δ
...s/snaps-simulator/src/features/simulation/sagas.ts 74.19% <20.00%> (-1.64%) ⬇️
...ntrollers/src/services/AbstractExecutionService.ts 89.43% <50.00%> (-3.37%) ⬇️
...ckages/snaps-controllers/src/snaps/location/npm.ts 90.20% <100.00%> (ø)
...tion-environments/src/iframe/IFrameSnapExecutor.ts 63.63% <100.00%> (ø)
...ments/src/node-process/ChildProcessSnapExecutor.ts 83.33% <100.00%> (ø)
...environments/src/node-thread/ThreadSnapExecutor.ts 83.33% <100.00%> (ø)
...ts/src/webworker/executor/WebWorkerSnapExecutor.ts 90.90% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding marked this pull request as ready for review September 11, 2023 12:34
@FrederikBolding FrederikBolding requested a review from a team as a code owner September 11, 2023 12:34
@FrederikBolding FrederikBolding merged commit 0c52d61 into main Sep 11, 2023
129 of 131 checks passed
@FrederikBolding FrederikBolding deleted the fb/remove-pump branch September 11, 2023 12:44
matthewwalsh0 added a commit that referenced this pull request Sep 16, 2023
This reverts commit 0c52d61.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants