-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/account creation dialog #1727
Conversation
5f59c93
to
b5a5356
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: [email protected], [email protected] |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhy are READMEs important?Package does not have a README. This may indicate a failed publish or a low quality package. Add a README to to the package and publish a new version. What are unmaintained packages?Package has not been updated in more than a year and may be unmaintained. Problems with the package may go unaddressed. Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
The `rpc-methods` repo should not have knowledge about the logic behind the `SnapKeyring` nor decide when its state needs to be saved. This PR passes the `saveSnapKeyring` callback function to `SnapKeyring`, and stops checking the methods being called. The `manageAccounts` method is still 100% covered, but since some code was removed, the global coverage threshold decreased.
Include account name in success message for demo. Co-authored-by: Matthew Walsh <[email protected]>
b4f0875
to
6ae5450
Compare
6ae5450
to
5bb6853
Compare
Progresses: https://github.com/MetaMask/accounts-planning/issues/14
Works alongside this change: MetaMask/metamask-extension#20684
See description of extension companion PR for details on how to test.
What did I change?
Your account is ready!
, create the account and add it.