Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/account creation dialog #1727

Closed
wants to merge 8 commits into from

Conversation

owencraston
Copy link

@owencraston owencraston commented Sep 6, 2023

Progresses: https://github.com/MetaMask/accounts-planning/issues/14
Works alongside this change: MetaMask/metamask-extension#20684

See description of extension companion PR for details on how to test.

What did I change?

  • I have added the approval controller methods as hooks to be passed into the manageAccountsImplementation in order to trigger an approval request from the user of the extension before an account is added.
  1. I start the approval, this is used to keep the approval flow open until I explicit end it or show the success screen.
  2. I requestApproval from the user
  3. upon confirmation, I showSuccess with the message Your account is ready!, create the account and add it.
  4. upon denial, I throw an error indicating the user denied the action and end the flow

@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@esbuild-plugins/node-globals-polyfill 0.2.3 eval +0 105 kB xmorse

🚮 Removed packages: [email protected], [email protected]

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
No README @esbuild-plugins/node-globals-polyfill 0.2.3
Unmaintained lodash.pickby 4.6.0
  • Last Publish: 8/13/2016, 5:43:24 PM

Next steps

Why are READMEs important?

Package does not have a README. This may indicate a failed publish or a low quality package.

Add a README to to the package and publish a new version.

What are unmaintained packages?

Package has not been updated in more than a year and may be unmaintained. Problems with the package may go unaddressed.

Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@owencraston owencraston marked this pull request as ready for review September 15, 2023 23:59
@owencraston owencraston requested a review from a team as a code owner September 15, 2023 23:59
danroc and others added 5 commits September 15, 2023 17:11
The `rpc-methods` repo should not have knowledge about the logic behind
the `SnapKeyring` nor decide when its state needs to be saved.

This PR passes the `saveSnapKeyring` callback function to `SnapKeyring`,
and stops checking the methods being called.

The `manageAccounts` method is still 100% covered, but since some code
was removed, the global coverage threshold decreased.
Include account name in success message for demo.

Co-authored-by: Matthew Walsh <[email protected]>
@owencraston owencraston force-pushed the feature/account-creation-dialog branch from b4f0875 to 6ae5450 Compare September 16, 2023 00:11
@owencraston owencraston force-pushed the feature/account-creation-dialog branch from 6ae5450 to 5bb6853 Compare September 16, 2023 00:18
@owencraston owencraston deleted the feature/account-creation-dialog branch September 20, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants