Add hardening for Request, Headers and Response endowments #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1695 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 239 239
Lines 5401 5401
Branches 836 836
=======================================
Hits 5178 5178
Misses 223 223
|
packages/snaps-execution-environments/src/common/endowments/network.ts
Outdated
Show resolved
Hide resolved
packages/snaps-execution-environments/src/common/endowments/endowments.test.browser.ts
Outdated
Show resolved
Hide resolved
packages/snaps-execution-environments/src/common/endowments/endowments.test.browser.ts
Outdated
Show resolved
Hide resolved
FrederikBolding
approved these changes
Aug 29, 2023
david0xd
force-pushed
the
dd/harden-more-endowments
branch
from
c248905 to
cf296fd
Compare
FrederikBolding
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Add hardening for Request, Headers and Response endowments * Update coverage thresholds * Refactor code (1) * Refactor code (2) * Revert coverage change
Gudahtt
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Add hardening for Request, Headers and Response endowments * Update coverage thresholds * Refactor code (1) * Refactor code (2) * Revert coverage change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add hardening for the three endowments that have been injected alongside
fetchwhenendowment:network-accesspermission is requested.These three endowments are not part of the default endowments (and should never be) and were only available when permission for network access is requested, because of that these endowments are hardened within the factory that is wrapping up
fetch.Result of testing fresh build of updated execution environment in flask:
When trying to modify these endowments from insde the snap (running Flask @ Chrome):
