Add onNameLookup export
#1394
Merged
Add onNameLookup export
#1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1394 +/- ##
==========================================
+ Coverage 95.74% 95.79% +0.04%
==========================================
Files 239 240 +1
Lines 5410 5469 +59
Branches 837 852 +15
==========================================
+ Hits 5180 5239 +59
Misses 230 230
☔ View full report in Codecov by Sentry. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
hmalik88
changed the title
onNameLookup exportonNameLookup export
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Mrtenz
previously requested changes
Sep 9, 2023
packages/snaps-execution-environments/src/common/BaseSnapExecutor.test.browser.ts
Outdated
Show resolved
Hide resolved
packages/snaps-execution-environments/src/common/validation.test.ts
Outdated
Show resolved
Hide resolved
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
FrederikBolding
previously approved these changes
Sep 12, 2023
Mrtenz
previously approved these changes
Sep 12, 2023
hmalik88
dismissed stale reviews from Mrtenz and FrederikBolding
via
5920bd3
FrederikBolding
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new endowment:
endowment:name-lookup& caveatchainIds. This will allow snaps to return a resolved account/domain based on a CAIP-2chainIdanddomainoraddresspassed to it.Note: There are types used from
namespace.tsthat now exist in@metamask/utils. I reviewed the PRs that copied over the types. I will replace usage with the types from@metamask/utilsin a subsequent PR (there's also one type that exists innamespace.tsthat is missing from@metamask/utils, so I will first open a PR for that).