From bbd1ac7f6e1caa7e62c94270f92c69f05039c99e Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 11:26:32 -0400 Subject: [PATCH 01/14] Add Snap allowlist process issue templates --- .github/ISSUE_TEMPLATE/new-snap.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/new-snap.md diff --git a/.github/ISSUE_TEMPLATE/new-snap.md b/.github/ISSUE_TEMPLATE/new-snap.md new file mode 100644 index 00000000..f4fba439 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/new-snap.md @@ -0,0 +1,19 @@ +--- +name: New Snap +about: The allowlisting process template for any new Snap +title: "[New Snap] Name of Snap here" +labels: allowlist-new-snap, allowlist-review-needed +assignees: '' + +--- + +# Allowlisting requirements + +A Snap needs to satisfy all items in the list below, with 1 approval from someone on the MetaMask Snaps team. + +- [ ] Is the Snap repository publicly accessible? +- [ ] Is the Snap distributed on [npm](https://www.npmjs.com/)? +- [ ] Has an approved third-party audit been performed and the original audit report attached to this issue? +- [ ] Has a complete list of discovered vulnerabilities from the audit report presented in this issue? +- [ ] For vulnerabilities that have been deemed necessary to be addressed, are the links to the fixes attached to this issue? +- [ ] For vulnerabilities that have been deemed not necessary to be addresses, is there reason to each of them documented in this issue? From b2972688e015ee90d85decbee98a3a64a52894c4 Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 14:53:58 -0400 Subject: [PATCH 02/14] Add different kinds of registry actions --- .github/ISSUE_TEMPLATE/block-snap.md | 13 +++++++++++++ .github/ISSUE_TEMPLATE/new-snap.md | 12 +++++------- .github/ISSUE_TEMPLATE/remove-snap.md | 13 +++++++++++++ .github/ISSUE_TEMPLATE/update-snap.md | 14 ++++++++++++++ 4 files changed, 45 insertions(+), 7 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/block-snap.md create mode 100644 .github/ISSUE_TEMPLATE/remove-snap.md create mode 100644 .github/ISSUE_TEMPLATE/update-snap.md diff --git a/.github/ISSUE_TEMPLATE/block-snap.md b/.github/ISSUE_TEMPLATE/block-snap.md new file mode 100644 index 00000000..b07d0b97 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/block-snap.md @@ -0,0 +1,13 @@ +--- +name: Block a Snap +about: Required for blocking an existing Snap (still listed in the registry but not accessible) +title: "[Block Snap] Name of Snap here" +labels: allowlist-block-snap, allowlist-review-needed +assignees: '' + +--- + +All items in the list below needs to be satisifed, with 1 approval from someone on the MetaMask Snaps team. + +- [ ] Is the reason for the block documented in this issue? +- [ ] Are the key parts of the communication with the developer to remediate the concerns documented in this issue? diff --git a/.github/ISSUE_TEMPLATE/new-snap.md b/.github/ISSUE_TEMPLATE/new-snap.md index f4fba439..d8bc5205 100644 --- a/.github/ISSUE_TEMPLATE/new-snap.md +++ b/.github/ISSUE_TEMPLATE/new-snap.md @@ -1,19 +1,17 @@ --- name: New Snap -about: The allowlisting process template for any new Snap +about: Required for every new Snap title: "[New Snap] Name of Snap here" labels: allowlist-new-snap, allowlist-review-needed assignees: '' --- -# Allowlisting requirements +All items in the list below needs to be satisifed, with 1 approval from someone on the MetaMask Snaps team. -A Snap needs to satisfy all items in the list below, with 1 approval from someone on the MetaMask Snaps team. - -- [ ] Is the Snap repository publicly accessible? -- [ ] Is the Snap distributed on [npm](https://www.npmjs.com/)? +- [ ] Is the Snap repository publicly accessible and linked in this ticket? +- [ ] Is the Snap distributed on [npm](https://www.npmjs.com/) and linked in this ticket? - [ ] Has an approved third-party audit been performed and the original audit report attached to this issue? -- [ ] Has a complete list of discovered vulnerabilities from the audit report presented in this issue? +- [ ] Is a complete list of discovered vulnerabilities from the audit documented in this issue? - [ ] For vulnerabilities that have been deemed necessary to be addressed, are the links to the fixes attached to this issue? - [ ] For vulnerabilities that have been deemed not necessary to be addresses, is there reason to each of them documented in this issue? diff --git a/.github/ISSUE_TEMPLATE/remove-snap.md b/.github/ISSUE_TEMPLATE/remove-snap.md new file mode 100644 index 00000000..67da0dbb --- /dev/null +++ b/.github/ISSUE_TEMPLATE/remove-snap.md @@ -0,0 +1,13 @@ +--- +name: Remove a Snap +about: Required for removing an existing Snap from the registry +title: "[Remove Snap] Name of Snap here" +labels: allowlist-remove-snap, allowlist-review-needed +assignees: '' + +--- + +All items in the list below needs to be satisifed, with 1 approval from someone on the MetaMask Snaps team. + +- [ ] Is the reason for the removal documented in this issue? +- [ ] Are the key parts of the communication with the developer to remediate the concerns documented in this issue? diff --git a/.github/ISSUE_TEMPLATE/update-snap.md b/.github/ISSUE_TEMPLATE/update-snap.md new file mode 100644 index 00000000..c3f1b570 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/update-snap.md @@ -0,0 +1,14 @@ +--- +name: Update a Snap +about: Required for every update for a Snap +title: "[Update Snap] Name of Snap here" +labels: allowlist-update-snap, allowlist-review-needed +assignees: '' + +--- + +All items in the list below needs to be satisifed, with 1 approval from someone on the MetaMask Snaps team. + +- [ ] Is the summary of the change documented in this ticket? +- [ ] Has a MetaMask Snaps team member reviewed whether the changes need to be vetted? +- [ ] If there are changes that need to be vetted, attach the assessment and the relevant fixes/remeditations to this issue. From 91e8131338c65439d1ae7e7be17d5ec7b61d856a Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 14:59:33 -0400 Subject: [PATCH 03/14] Add generic label for ease of filtering --- .github/ISSUE_TEMPLATE/block-snap.md | 2 +- .github/ISSUE_TEMPLATE/new-snap.md | 2 +- .github/ISSUE_TEMPLATE/remove-snap.md | 2 +- .github/ISSUE_TEMPLATE/update-snap.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/block-snap.md b/.github/ISSUE_TEMPLATE/block-snap.md index b07d0b97..1879e2af 100644 --- a/.github/ISSUE_TEMPLATE/block-snap.md +++ b/.github/ISSUE_TEMPLATE/block-snap.md @@ -2,7 +2,7 @@ name: Block a Snap about: Required for blocking an existing Snap (still listed in the registry but not accessible) title: "[Block Snap] Name of Snap here" -labels: allowlist-block-snap, allowlist-review-needed +labels: allowlist,allowlist-block-snap, allowlist-review-needed assignees: '' --- diff --git a/.github/ISSUE_TEMPLATE/new-snap.md b/.github/ISSUE_TEMPLATE/new-snap.md index d8bc5205..6251a1b0 100644 --- a/.github/ISSUE_TEMPLATE/new-snap.md +++ b/.github/ISSUE_TEMPLATE/new-snap.md @@ -2,7 +2,7 @@ name: New Snap about: Required for every new Snap title: "[New Snap] Name of Snap here" -labels: allowlist-new-snap, allowlist-review-needed +labels: allowlist,allowlist-new-snap, allowlist-review-needed assignees: '' --- diff --git a/.github/ISSUE_TEMPLATE/remove-snap.md b/.github/ISSUE_TEMPLATE/remove-snap.md index 67da0dbb..9bbba54c 100644 --- a/.github/ISSUE_TEMPLATE/remove-snap.md +++ b/.github/ISSUE_TEMPLATE/remove-snap.md @@ -2,7 +2,7 @@ name: Remove a Snap about: Required for removing an existing Snap from the registry title: "[Remove Snap] Name of Snap here" -labels: allowlist-remove-snap, allowlist-review-needed +labels: allowlist,allowlist-remove-snap, allowlist-review-needed assignees: '' --- diff --git a/.github/ISSUE_TEMPLATE/update-snap.md b/.github/ISSUE_TEMPLATE/update-snap.md index c3f1b570..17b64687 100644 --- a/.github/ISSUE_TEMPLATE/update-snap.md +++ b/.github/ISSUE_TEMPLATE/update-snap.md @@ -2,7 +2,7 @@ name: Update a Snap about: Required for every update for a Snap title: "[Update Snap] Name of Snap here" -labels: allowlist-update-snap, allowlist-review-needed +labels: allowlist,allowlist-update-snap, allowlist-review-needed assignees: '' --- From 0d15a21a09143605f58a0e575fa60e686692a47d Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 15:14:58 -0400 Subject: [PATCH 04/14] Edits from pairing session with Christian --- .github/ISSUE_TEMPLATE/block-snap.md | 3 +-- .github/ISSUE_TEMPLATE/new-snap.md | 6 +++--- .github/ISSUE_TEMPLATE/remove-snap.md | 2 +- .github/ISSUE_TEMPLATE/update-snap.md | 4 ++-- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/block-snap.md b/.github/ISSUE_TEMPLATE/block-snap.md index 1879e2af..48fa2853 100644 --- a/.github/ISSUE_TEMPLATE/block-snap.md +++ b/.github/ISSUE_TEMPLATE/block-snap.md @@ -2,7 +2,7 @@ name: Block a Snap about: Required for blocking an existing Snap (still listed in the registry but not accessible) title: "[Block Snap] Name of Snap here" -labels: allowlist,allowlist-block-snap, allowlist-review-needed +labels: allowlist,allowlist-block-snap assignees: '' --- @@ -10,4 +10,3 @@ assignees: '' All items in the list below needs to be satisifed, with 1 approval from someone on the MetaMask Snaps team. - [ ] Is the reason for the block documented in this issue? -- [ ] Are the key parts of the communication with the developer to remediate the concerns documented in this issue? diff --git a/.github/ISSUE_TEMPLATE/new-snap.md b/.github/ISSUE_TEMPLATE/new-snap.md index 6251a1b0..cbd8c23e 100644 --- a/.github/ISSUE_TEMPLATE/new-snap.md +++ b/.github/ISSUE_TEMPLATE/new-snap.md @@ -2,7 +2,7 @@ name: New Snap about: Required for every new Snap title: "[New Snap] Name of Snap here" -labels: allowlist,allowlist-new-snap, allowlist-review-needed +labels: allowlist,allowlist-new-snap assignees: '' --- @@ -11,7 +11,7 @@ All items in the list below needs to be satisifed, with 1 approval from someone - [ ] Is the Snap repository publicly accessible and linked in this ticket? - [ ] Is the Snap distributed on [npm](https://www.npmjs.com/) and linked in this ticket? -- [ ] Has an approved third-party audit been performed and the original audit report attached to this issue? +- [ ] Has an audit been performed and the audit report attached or linked in this issue? - [ ] Is a complete list of discovered vulnerabilities from the audit documented in this issue? - [ ] For vulnerabilities that have been deemed necessary to be addressed, are the links to the fixes attached to this issue? -- [ ] For vulnerabilities that have been deemed not necessary to be addresses, is there reason to each of them documented in this issue? +- [ ] For vulnerabilities that have been deemed not necessary to be addressed, is a reason for each of them documented in this issue? diff --git a/.github/ISSUE_TEMPLATE/remove-snap.md b/.github/ISSUE_TEMPLATE/remove-snap.md index 9bbba54c..f1db6e02 100644 --- a/.github/ISSUE_TEMPLATE/remove-snap.md +++ b/.github/ISSUE_TEMPLATE/remove-snap.md @@ -2,7 +2,7 @@ name: Remove a Snap about: Required for removing an existing Snap from the registry title: "[Remove Snap] Name of Snap here" -labels: allowlist,allowlist-remove-snap, allowlist-review-needed +labels: allowlist,allowlist-remove-snap assignees: '' --- diff --git a/.github/ISSUE_TEMPLATE/update-snap.md b/.github/ISSUE_TEMPLATE/update-snap.md index 17b64687..49692e85 100644 --- a/.github/ISSUE_TEMPLATE/update-snap.md +++ b/.github/ISSUE_TEMPLATE/update-snap.md @@ -2,7 +2,7 @@ name: Update a Snap about: Required for every update for a Snap title: "[Update Snap] Name of Snap here" -labels: allowlist,allowlist-update-snap, allowlist-review-needed +labels: allowlist,allowlist-update-snap assignees: '' --- @@ -11,4 +11,4 @@ All items in the list below needs to be satisifed, with 1 approval from someone - [ ] Is the summary of the change documented in this ticket? - [ ] Has a MetaMask Snaps team member reviewed whether the changes need to be vetted? -- [ ] If there are changes that need to be vetted, attach the assessment and the relevant fixes/remeditations to this issue. +- [ ] If there are changes that need to be vetted, attach a description and the relevant fixes/remediations to this issue. From e83d4a71c30a5bd5862200244cf6fdc7a2fb2a3e Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 15:28:03 -0400 Subject: [PATCH 05/14] Add notes to blocking and removing --- .github/ISSUE_TEMPLATE/block-snap.md | 2 ++ .github/ISSUE_TEMPLATE/remove-snap.md | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/block-snap.md b/.github/ISSUE_TEMPLATE/block-snap.md index 48fa2853..5fd3c36c 100644 --- a/.github/ISSUE_TEMPLATE/block-snap.md +++ b/.github/ISSUE_TEMPLATE/block-snap.md @@ -7,6 +7,8 @@ assignees: '' --- +Note: Blocking a Snap means that both new and existing users cannot use the Snap. + All items in the list below needs to be satisifed, with 1 approval from someone on the MetaMask Snaps team. - [ ] Is the reason for the block documented in this issue? diff --git a/.github/ISSUE_TEMPLATE/remove-snap.md b/.github/ISSUE_TEMPLATE/remove-snap.md index f1db6e02..730e4f20 100644 --- a/.github/ISSUE_TEMPLATE/remove-snap.md +++ b/.github/ISSUE_TEMPLATE/remove-snap.md @@ -7,6 +7,8 @@ assignees: '' --- +Note: Removing a Snap from the registry means that users who have installed the Snap may continue to use it. New users will not be able to install the Snap. + All items in the list below needs to be satisifed, with 1 approval from someone on the MetaMask Snaps team. - [ ] Is the reason for the removal documented in this issue? From 23545359a3ea0dc54f01d772b144057e4326ca39 Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 15:28:58 -0400 Subject: [PATCH 06/14] Update .github/ISSUE_TEMPLATE/update-snap.md Co-authored-by: Maarten Zuidhoorn --- .github/ISSUE_TEMPLATE/update-snap.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/update-snap.md b/.github/ISSUE_TEMPLATE/update-snap.md index 49692e85..dae82ac3 100644 --- a/.github/ISSUE_TEMPLATE/update-snap.md +++ b/.github/ISSUE_TEMPLATE/update-snap.md @@ -7,7 +7,7 @@ assignees: '' --- -All items in the list below needs to be satisifed, with 1 approval from someone on the MetaMask Snaps team. +All items in the list below needs to be satisfied, with 1 approval from someone on the MetaMask Snaps team. - [ ] Is the summary of the change documented in this ticket? - [ ] Has a MetaMask Snaps team member reviewed whether the changes need to be vetted? From 323892cc82fb7ebb248440ecb75217e28431923d Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 15:29:12 -0400 Subject: [PATCH 07/14] Update .github/ISSUE_TEMPLATE/remove-snap.md Co-authored-by: Maarten Zuidhoorn --- .github/ISSUE_TEMPLATE/remove-snap.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/remove-snap.md b/.github/ISSUE_TEMPLATE/remove-snap.md index 730e4f20..c7c10368 100644 --- a/.github/ISSUE_TEMPLATE/remove-snap.md +++ b/.github/ISSUE_TEMPLATE/remove-snap.md @@ -9,7 +9,7 @@ assignees: '' Note: Removing a Snap from the registry means that users who have installed the Snap may continue to use it. New users will not be able to install the Snap. -All items in the list below needs to be satisifed, with 1 approval from someone on the MetaMask Snaps team. +All items in the list below needs to be satisfied, with 1 approval from someone on the MetaMask Snaps team. - [ ] Is the reason for the removal documented in this issue? - [ ] Are the key parts of the communication with the developer to remediate the concerns documented in this issue? From 8c6553793ef4b39e1a54ee8958b0093f73c821ef Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 15:29:26 -0400 Subject: [PATCH 08/14] Update .github/ISSUE_TEMPLATE/new-snap.md Co-authored-by: Maarten Zuidhoorn --- .github/ISSUE_TEMPLATE/new-snap.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/new-snap.md b/.github/ISSUE_TEMPLATE/new-snap.md index cbd8c23e..3ca74b56 100644 --- a/.github/ISSUE_TEMPLATE/new-snap.md +++ b/.github/ISSUE_TEMPLATE/new-snap.md @@ -7,7 +7,7 @@ assignees: '' --- -All items in the list below needs to be satisifed, with 1 approval from someone on the MetaMask Snaps team. +All items in the list below needs to be satisfied, with 1 approval from someone on the MetaMask Snaps team. - [ ] Is the Snap repository publicly accessible and linked in this ticket? - [ ] Is the Snap distributed on [npm](https://www.npmjs.com/) and linked in this ticket? From 65c79268d10da490531ef1188326fb8547549eac Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 15:29:43 -0400 Subject: [PATCH 09/14] Update .github/ISSUE_TEMPLATE/block-snap.md Co-authored-by: Maarten Zuidhoorn --- .github/ISSUE_TEMPLATE/block-snap.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/block-snap.md b/.github/ISSUE_TEMPLATE/block-snap.md index 5fd3c36c..61d06cb1 100644 --- a/.github/ISSUE_TEMPLATE/block-snap.md +++ b/.github/ISSUE_TEMPLATE/block-snap.md @@ -9,6 +9,14 @@ assignees: '' Note: Blocking a Snap means that both new and existing users cannot use the Snap. -All items in the list below needs to be satisifed, with 1 approval from someone on the MetaMask Snaps team. +## Description + +... + +## Checklist + + - [ ] Is the reason for the block documented in this issue? From ac7cef243957ff9d8caa440b554c9f527b4a6273 Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 15:29:51 -0400 Subject: [PATCH 10/14] Update .github/ISSUE_TEMPLATE/update-snap.md Co-authored-by: Maarten Zuidhoorn --- .github/ISSUE_TEMPLATE/update-snap.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/update-snap.md b/.github/ISSUE_TEMPLATE/update-snap.md index dae82ac3..fd92415a 100644 --- a/.github/ISSUE_TEMPLATE/update-snap.md +++ b/.github/ISSUE_TEMPLATE/update-snap.md @@ -4,7 +4,6 @@ about: Required for every update for a Snap title: "[Update Snap] Name of Snap here" labels: allowlist,allowlist-update-snap assignees: '' - --- All items in the list below needs to be satisfied, with 1 approval from someone on the MetaMask Snaps team. From 0b6cc261287c81c6e471c9e07e2d47f181ca1562 Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 15:36:24 -0400 Subject: [PATCH 11/14] Add final action to merge PR --- .github/ISSUE_TEMPLATE/block-snap.md | 11 ++++------- .github/ISSUE_TEMPLATE/new-snap.md | 7 ++++++- .github/ISSUE_TEMPLATE/remove-snap.md | 7 ++++++- .github/ISSUE_TEMPLATE/update-snap.md | 7 ++++++- 4 files changed, 22 insertions(+), 10 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/block-snap.md b/.github/ISSUE_TEMPLATE/block-snap.md index 61d06cb1..2c804c15 100644 --- a/.github/ISSUE_TEMPLATE/block-snap.md +++ b/.github/ISSUE_TEMPLATE/block-snap.md @@ -7,16 +7,13 @@ assignees: '' --- -Note: Blocking a Snap means that both new and existing users cannot use the Snap. - ## Description -... - -## Checklist +Note: Blocking a Snap means that both new and existing users cannot use the Snap. - + +## Checklist - [ ] Is the reason for the block documented in this issue? +- [ ] The corresponding pull request in this repo has been merged. diff --git a/.github/ISSUE_TEMPLATE/new-snap.md b/.github/ISSUE_TEMPLATE/new-snap.md index 3ca74b56..cc52adcb 100644 --- a/.github/ISSUE_TEMPLATE/new-snap.md +++ b/.github/ISSUE_TEMPLATE/new-snap.md @@ -7,7 +7,11 @@ assignees: '' --- -All items in the list below needs to be satisfied, with 1 approval from someone on the MetaMask Snaps team. +## Description + +All items in the list below needs to be satisfied. + +## Checklist - [ ] Is the Snap repository publicly accessible and linked in this ticket? - [ ] Is the Snap distributed on [npm](https://www.npmjs.com/) and linked in this ticket? @@ -15,3 +19,4 @@ All items in the list below needs to be satisfied, with 1 approval from someone - [ ] Is a complete list of discovered vulnerabilities from the audit documented in this issue? - [ ] For vulnerabilities that have been deemed necessary to be addressed, are the links to the fixes attached to this issue? - [ ] For vulnerabilities that have been deemed not necessary to be addressed, is a reason for each of them documented in this issue? +- [ ] The corresponding pull request in this repo has been merged. diff --git a/.github/ISSUE_TEMPLATE/remove-snap.md b/.github/ISSUE_TEMPLATE/remove-snap.md index c7c10368..f279352c 100644 --- a/.github/ISSUE_TEMPLATE/remove-snap.md +++ b/.github/ISSUE_TEMPLATE/remove-snap.md @@ -7,9 +7,14 @@ assignees: '' --- +## Description + Note: Removing a Snap from the registry means that users who have installed the Snap may continue to use it. New users will not be able to install the Snap. -All items in the list below needs to be satisfied, with 1 approval from someone on the MetaMask Snaps team. +All items in the list below needs to be satisfied. + +## Checklist - [ ] Is the reason for the removal documented in this issue? - [ ] Are the key parts of the communication with the developer to remediate the concerns documented in this issue? +- [ ] The corresponding pull request in this repo has been merged. diff --git a/.github/ISSUE_TEMPLATE/update-snap.md b/.github/ISSUE_TEMPLATE/update-snap.md index fd92415a..9f582cb3 100644 --- a/.github/ISSUE_TEMPLATE/update-snap.md +++ b/.github/ISSUE_TEMPLATE/update-snap.md @@ -6,8 +6,13 @@ labels: allowlist,allowlist-update-snap assignees: '' --- -All items in the list below needs to be satisfied, with 1 approval from someone on the MetaMask Snaps team. +## Description + +All items in the list below needs to be satisfied. + +## Checklist - [ ] Is the summary of the change documented in this ticket? - [ ] Has a MetaMask Snaps team member reviewed whether the changes need to be vetted? - [ ] If there are changes that need to be vetted, attach a description and the relevant fixes/remediations to this issue. +- [ ] The corresponding pull request in this repo has been merged. From 57c94295a1e446384551f817abec642a38a88d9f Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 15:36:54 -0400 Subject: [PATCH 12/14] Apply suggestions from code review Co-authored-by: Maarten Zuidhoorn --- .github/ISSUE_TEMPLATE/block-snap.md | 1 - .github/ISSUE_TEMPLATE/new-snap.md | 1 - .github/ISSUE_TEMPLATE/remove-snap.md | 1 - 3 files changed, 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/block-snap.md b/.github/ISSUE_TEMPLATE/block-snap.md index 2c804c15..ad86b00d 100644 --- a/.github/ISSUE_TEMPLATE/block-snap.md +++ b/.github/ISSUE_TEMPLATE/block-snap.md @@ -4,7 +4,6 @@ about: Required for blocking an existing Snap (still listed in the registry but title: "[Block Snap] Name of Snap here" labels: allowlist,allowlist-block-snap assignees: '' - --- ## Description diff --git a/.github/ISSUE_TEMPLATE/new-snap.md b/.github/ISSUE_TEMPLATE/new-snap.md index cc52adcb..339da135 100644 --- a/.github/ISSUE_TEMPLATE/new-snap.md +++ b/.github/ISSUE_TEMPLATE/new-snap.md @@ -4,7 +4,6 @@ about: Required for every new Snap title: "[New Snap] Name of Snap here" labels: allowlist,allowlist-new-snap assignees: '' - --- ## Description diff --git a/.github/ISSUE_TEMPLATE/remove-snap.md b/.github/ISSUE_TEMPLATE/remove-snap.md index f279352c..b5b080c1 100644 --- a/.github/ISSUE_TEMPLATE/remove-snap.md +++ b/.github/ISSUE_TEMPLATE/remove-snap.md @@ -4,7 +4,6 @@ about: Required for removing an existing Snap from the registry title: "[Remove Snap] Name of Snap here" labels: allowlist,allowlist-remove-snap assignees: '' - --- ## Description From 4ccb9a3903aa7fc6252971f3558932ecf5cd35f8 Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 15:52:10 -0400 Subject: [PATCH 13/14] Run prettier --- .github/ISSUE_TEMPLATE/block-snap.md | 2 +- .github/ISSUE_TEMPLATE/new-snap.md | 2 +- .github/ISSUE_TEMPLATE/remove-snap.md | 2 +- .github/ISSUE_TEMPLATE/update-snap.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/block-snap.md b/.github/ISSUE_TEMPLATE/block-snap.md index ad86b00d..809aa957 100644 --- a/.github/ISSUE_TEMPLATE/block-snap.md +++ b/.github/ISSUE_TEMPLATE/block-snap.md @@ -1,7 +1,7 @@ --- name: Block a Snap about: Required for blocking an existing Snap (still listed in the registry but not accessible) -title: "[Block Snap] Name of Snap here" +title: '[Block Snap] Name of Snap here' labels: allowlist,allowlist-block-snap assignees: '' --- diff --git a/.github/ISSUE_TEMPLATE/new-snap.md b/.github/ISSUE_TEMPLATE/new-snap.md index 339da135..28d57eac 100644 --- a/.github/ISSUE_TEMPLATE/new-snap.md +++ b/.github/ISSUE_TEMPLATE/new-snap.md @@ -1,7 +1,7 @@ --- name: New Snap about: Required for every new Snap -title: "[New Snap] Name of Snap here" +title: '[New Snap] Name of Snap here' labels: allowlist,allowlist-new-snap assignees: '' --- diff --git a/.github/ISSUE_TEMPLATE/remove-snap.md b/.github/ISSUE_TEMPLATE/remove-snap.md index b5b080c1..befb8507 100644 --- a/.github/ISSUE_TEMPLATE/remove-snap.md +++ b/.github/ISSUE_TEMPLATE/remove-snap.md @@ -1,7 +1,7 @@ --- name: Remove a Snap about: Required for removing an existing Snap from the registry -title: "[Remove Snap] Name of Snap here" +title: '[Remove Snap] Name of Snap here' labels: allowlist,allowlist-remove-snap assignees: '' --- diff --git a/.github/ISSUE_TEMPLATE/update-snap.md b/.github/ISSUE_TEMPLATE/update-snap.md index 9f582cb3..d9aa7667 100644 --- a/.github/ISSUE_TEMPLATE/update-snap.md +++ b/.github/ISSUE_TEMPLATE/update-snap.md @@ -1,7 +1,7 @@ --- name: Update a Snap about: Required for every update for a Snap -title: "[Update Snap] Name of Snap here" +title: '[Update Snap] Name of Snap here' labels: allowlist,allowlist-update-snap assignees: '' --- From 8bed67a724feb42421e3c58b59c28c5930711e61 Mon Sep 17 00:00:00 2001 From: Ken Kan Date: Wed, 6 Sep 2023 15:53:07 -0400 Subject: [PATCH 14/14] Move checklist description --- .github/ISSUE_TEMPLATE/block-snap.md | 4 ++-- .github/ISSUE_TEMPLATE/new-snap.md | 4 +--- .github/ISSUE_TEMPLATE/remove-snap.md | 4 ++-- .github/ISSUE_TEMPLATE/update-snap.md | 4 +--- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/block-snap.md b/.github/ISSUE_TEMPLATE/block-snap.md index 809aa957..c8465c5c 100644 --- a/.github/ISSUE_TEMPLATE/block-snap.md +++ b/.github/ISSUE_TEMPLATE/block-snap.md @@ -10,9 +10,9 @@ assignees: '' Note: Blocking a Snap means that both new and existing users cannot use the Snap. -All items in the list below needs to be satisfied. - ## Checklist +All items in the list below needs to be satisfied. + - [ ] Is the reason for the block documented in this issue? - [ ] The corresponding pull request in this repo has been merged. diff --git a/.github/ISSUE_TEMPLATE/new-snap.md b/.github/ISSUE_TEMPLATE/new-snap.md index 28d57eac..59e2ce3c 100644 --- a/.github/ISSUE_TEMPLATE/new-snap.md +++ b/.github/ISSUE_TEMPLATE/new-snap.md @@ -6,12 +6,10 @@ labels: allowlist,allowlist-new-snap assignees: '' --- -## Description +## Checklist All items in the list below needs to be satisfied. -## Checklist - - [ ] Is the Snap repository publicly accessible and linked in this ticket? - [ ] Is the Snap distributed on [npm](https://www.npmjs.com/) and linked in this ticket? - [ ] Has an audit been performed and the audit report attached or linked in this issue? diff --git a/.github/ISSUE_TEMPLATE/remove-snap.md b/.github/ISSUE_TEMPLATE/remove-snap.md index befb8507..b2da84a9 100644 --- a/.github/ISSUE_TEMPLATE/remove-snap.md +++ b/.github/ISSUE_TEMPLATE/remove-snap.md @@ -10,10 +10,10 @@ assignees: '' Note: Removing a Snap from the registry means that users who have installed the Snap may continue to use it. New users will not be able to install the Snap. -All items in the list below needs to be satisfied. - ## Checklist +All items in the list below needs to be satisfied. + - [ ] Is the reason for the removal documented in this issue? - [ ] Are the key parts of the communication with the developer to remediate the concerns documented in this issue? - [ ] The corresponding pull request in this repo has been merged. diff --git a/.github/ISSUE_TEMPLATE/update-snap.md b/.github/ISSUE_TEMPLATE/update-snap.md index d9aa7667..aa18ede3 100644 --- a/.github/ISSUE_TEMPLATE/update-snap.md +++ b/.github/ISSUE_TEMPLATE/update-snap.md @@ -6,12 +6,10 @@ labels: allowlist,allowlist-update-snap assignees: '' --- -## Description +## Checklist All items in the list below needs to be satisfied. -## Checklist - - [ ] Is the summary of the change documented in this ticket? - [ ] Has a MetaMask Snaps team member reviewed whether the changes need to be vetted? - [ ] If there are changes that need to be vetted, attach a description and the relevant fixes/remediations to this issue.