-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0 #111
2.0.0 #111
Conversation
Co-authored-by: Maarten Zuidhoorn <[email protected]>
While this is technically a breaking change in the type I don't think it's really necessary to do a major bump for it. What do you think? |
If it's breaking, technically or not, I think we should do a major bump. 😅 |
If we consider that this was a type-only change - TypeScript being a developer tool and strictly optional - I would tend to agree that breaking type interfaces shouldn't necessitate a breaking change. However:
I guess two options where both sound reasonable to me:
|
Yeah, you are right. However, for our use we do not currently rely on the runtime behaviour. Which is why I brought it up. But I am fine with following semver properly here as well. Just wanted to voice the option, because it wouldn't be breaking with our usage. |
This reverts commit a689dc9. The release failed and will be rescheduled as-is.
This is the release candidate for version 2.0.0.