Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Chain config setup #62

Merged
merged 23 commits into from
Mar 21, 2024
Merged

fix: Chain config setup #62

merged 23 commits into from
Mar 21, 2024

Conversation

montelaidev
Copy link
Contributor

This PR updates the Chain config setting from the ui to make it more friendly.

@montelaidev montelaidev requested a review from a team as a code owner March 6, 2024 08:54
@montelaidev montelaidev changed the title Fix/chain config setup fix: Chain config setup Mar 6, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Mar 7, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] Transitive: environment, network +29 5.03 MB metamaskbot
npm/@metamask/[email protected] Transitive: environment, network +49 8.47 MB metamaskbot
npm/@metamask/[email protected] Transitive: environment, network +38 5.64 MB metamaskbot
npm/@metamask/[email protected] network Transitive: environment +46 7.94 MB metamaskbot

🚮 Removed packages: npm/@gar/[email protected], npm/@lavamoat/[email protected], npm/@metamask/[email protected], npm/@npmcli/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

ccharly
ccharly reviewed Mar 13, 2024
View reviewed changes
packages/site/src/components/ChainConfig.tsx Outdated Show resolved Hide resolved
packages/site/src/utils/snap.ts Outdated Show resolved Hide resolved
packages/site/src/components/ChainConfig.tsx Outdated Show resolved Hide resolved
packages/site/src/utils/snap.ts Outdated Show resolved Hide resolved
packages/snap/src/keyring.ts Show resolved Hide resolved
ccharly
ccharly reviewed Mar 19, 2024
View reviewed changes
packages/site/src/components/ChainConfig.tsx Outdated Show resolved Hide resolved
packages/site/src/components/ChainConfig.tsx Show resolved Hide resolved
packages/site/src/utils/snap.ts Outdated Show resolved Hide resolved
packages/site/src/utils/snap.ts Show resolved Hide resolved
packages/snap/src/keyring.ts Show resolved Hide resolved
@montelaidev montelaidev requested a review from ccharly March 20, 2024 09:24
ccharly
ccharly previously approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (didn't test it myself though, but the CI does 💪)

@montelaidev montelaidev merged commit 1acb30c into main Mar 21, 2024
11 checks passed
@montelaidev montelaidev deleted the fix/chain-config-setup branch March 21, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-g-j k-g-j k-g-j left review comments

@ccharly ccharly ccharly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@montelaidev @ccharly @k-g-j