Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/update tests #6

Closed
wants to merge 68 commits into from
Closed

Feat/update tests #6

wants to merge 68 commits into from

Conversation

k-g-j
Copy link
Contributor

@k-g-j k-g-j commented Jan 23, 2024 •
edited
Loading

In this PR

  • Added tests for sending initCode with patch user op and sign user op
  • Removed user op methods from the front end

See #7 for additional test refactors required

k-g-j and others added 30 commits January 11, 2024 12:12
@k-g-j
feat: init commit with createAccount and state updates
97f4eb4
@k-g-j
feat: init commit with createAccount and state updates
958ee49
@k-g-j
Added [email protected] to dependencies
2cdfde5
@k-g-j
Added sign transaction to unsupported methods
4ebffef
@k-g-j
Added initCode generation to createAccount
10be421
@k-g-j
Removed unnecessary error throw and set deployed to false in createAc…
cabd8fd 
…count
@k-g-j
Init: removed async methods and flows
995518b
@k-g-j
Added method stubs for user operations
a6e7d77
@k-g-j
Started implementing method to prepare userOp
53629a4
@k-g-j
Finished implementing prepareUserOp
187e6e4
@k-g-j
Merge remote-tracking branch 'origin/feat/deploy-factories' into feat…
c9e90f1 
…/implement-4337-methods

# Conflicts:
#	packages/snap/package.json
#	packages/snap/src/constants/aa-factories.ts
#	packages/snap/src/constants/chain-ids.ts
#	packages/snap/src/keyring.ts
#	yarn.lock
@k-g-j
Updated implementation for preparing and signing requests and merged …
7e62b2c 
…with deploy contracts branch
@k-g-j
Updated dummy values and added urls to env.sample
174178f
@k-g-j
Updated paymaster url in env.sample
fea673b
@k-g-j
Added salt to wallet state and address for paymaster to env.sample
24ac8da
@montelaidev
feat: impl patchUserOperation
b0ca7da
@montelaidev
fix: add network-access permission
1f2ab26
@montelaidev
fix: return types for prepareUserOperation
32d20d9
@montelaidev
fix: SimpleAccountFactory getAddress to getAccountAddress
70269f2
@montelaidev
fix: update keyring api on site
7fbedce
@montelaidev
fix: change salt to be dynamic
daced3d
@k-g-j
updated front end to import private key in create account and include…
c719043 
… userOp methods
@k-g-j
Updated snap name on front end
5aed321
@montelaidev
Merge remote-tracking branch 'origin/feat/update-front-end' into feat…
e3bab75 
…/implement-patch-user-operation
@montelaidev
feat: update hardhat config with chainId and max accounts
73fb85f
@montelaidev
fix: sign userOperation
40aa29f
@montelaidev
chore: update readme
5f922ca
@montelaidev
fix: patchUserOperation to use verifying paymaster
0d894b7
@k-g-j
Added compile step to build
7320685
@montelaidev
fix: remove usage of jest env
164206a
montelaidev and others added 21 commits January 24, 2024 17:54
@montelaidev
feat: add .prettierignore
d01e3f2
@montelaidev
fix: remove unused variables
0a369aa
@montelaidev
fix: update env files for snap
9a62f45
@montelaidev
fix: add build step for test to create types
bcefc98
@montelaidev
fix: remove @uniswap/sdk-core
ba50085
@montelaidev
bump: metamask/providers
bce4f41
@montelaidev
fix: dynamically set networks based on env
0b83f14
@montelaidev
chore: update yarn lock
c76281c
@montelaidev
chore: fix lint
f209e44
@montelaidev
fix: remove prettier for cache, coverage and artifacts
fca138a
@montelaidev
fix: lint
194227a
@k-g-j
Added salt ability to front end create account
24a7573
@k-g-j
Added ability to set chain configuration via keyring and UI
73d8c08
@k-g-j
Fix: wrap user op hash in bytes before signing
5c70fdc
@k-g-j
Fix: updated chainIdDecimal to base 10
9558528
@k-g-j
Fix: return '0x' for dummy paymaster and data
3b87680
@k-g-j
Fix: do not destructure transaction array in prepareUserOp
8c83803
@k-g-j
Updated TODOs for validation and setting if an account is deployed
c3aeb66
@k-g-j
Added validation to setting the config
0102d64
@k-g-j
Removed userOp methods from front-end
05c7074
@k-g-j
Updated keyring tests for init codes
fbba5f4
@k-g-j k-g-j force-pushed the feat/update-tests branch from d4794f6 to fbba5f4 Compare January 24, 2024 14:50
k-g-j added 5 commits January 24, 2024 09:50
@k-g-j
Updating tests
e2522d4
@k-g-j
Merge remote-tracking branch 'origin/feat/implement-patch-user-operat…
98e89b1 
…ion' into feat/update-tests

# Conflicts:
#	packages/site/src/pages/index.tsx
#	packages/snap/snap.manifest.json
#	packages/snap/src/keyring.test.ts
#	packages/snap/src/keyring.ts
@k-g-j
Updated tests to include init code in prepare UserOp and sign UserOp
8ccf550
@k-g-j
debugging deploying account with init code
4ffd780
@k-g-j
Fixed bug in testing deployment of account
c2b8fd7
@k-g-j k-g-j closed this Feb 13, 2024
@k-g-j
Copy link
Contributor Author

k-g-j commented Feb 13, 2024

Closing because already merged and no longer relevant

livingrockrises added a commit to bcnmy/smart-account-keyring-template that referenced this pull request Feb 24, 2024
@livingrockrises
Merge pull request MetaMask#6 from livingrockrises/feat/account-recov…
5889785 
…ery-flows-mint-nft

dev notes + account recovery (only setup) + guardian sig + mint nft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-g-j @montelaidev